Repository navigation
commands/logs module missing in pypi package #33463
Description
Bug description
Hi, when I tried to upgrade to 5.0.0rc2, I ran into some import errors, until I realized that the apache-superset 5.0.0rc2 package on pypi is missing superset/commands/logs/prune.py (here).
I could patch the file from the tagged GH branch (here), where it is present, into my local pip folder of superset and then everything worked fine.
Wanted to let you know, as this is a very unexpected bug to fix. Also I am curious on how the file went missing on its way to pypi.
Screenshots/recordings
No response
Superset version
5.0.0rc2
Python version
3.11
Node version
16
Browser
Firefox
Additional context
No response
Checklist
- I have searched Superset docs and Slack and didn't find a solution to my problem.
- I have searched the GitHub issue tracker and didn't find a similar bug report.
- I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Activity
dosubot commentedon May 16, 2025
Hey there, @glennDittmann! 👋 I'm a friendly bot here to help you tackle bugs, answer questions, and support your journey as a contributor. I'm here while we wait for a human maintainer to jump in. Let's get to the bottom of this together! 😊
The issue you're experiencing with the missing
superset/commands/logs/prune.pymodule in the PyPI package forapache-superset 5.0.0rc2could be due to an oversight in the packaging process. The packaging process for Apache Superset is managed using thesetup.pyscript, which includes specifying which files and directories should be included in the package [1].To resolve this, you can manually include the missing file as you have done, or you might want to check if there are any recent changes or updates in the Superset codebase related to the packaging process that could have affected file inclusion. This could involve reviewing the
setup.pyconfiguration or any related scripts that handle file inclusion during the packaging process.If this is a recurring issue, it might be worth checking if there are any updates or patches available that address this specific problem in the release candidate.
To reply, just mention @dosu.
Docs are dead. Just use Dosu.
rusackas commentedon May 16, 2025
Indeed, that script is more recent than the 5.0 cut. I'm not sure if @michael-s-molina will want to cherry it into the next candidate, or if it'll come in a subsequent release.
michael-s-molina commentedon May 16, 2025
Hi @glennDittmann. Thank you for the issue. This was perceived by another user too and we submitted a fix in #33059 which will be included in RC3.