Skip to content

### Inconsistent Text Color Theme Fallback <sub>![category Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub> #35100

Closed

Description

Inconsistent Text Color Theme Fallback category Functionality

Tell me more
What is the issue?

The colorTextSecondary fallback to colorText may result in inconsistent text color behavior when themes are changed.

Why this matters

If colorTextSecondary is undefined in some themes but defined in others, the text color will switch between two different color variables, potentially causing unexpected visual changes.

Suggested change ∙ Feature Preview

Use only one theme color variable to ensure consistent behavior across themes:

color: ${theme.colorText};
Provide feedback to improve future suggestions

Nice Catch Incorrect Not in Scope Not in coding standard Other

💬 Looking for more details? Reply to this comment to chat with Korbit.

Originally posted by @korbit-ai[bot] in #35096 (comment)

Activity

  1. dosubot commented on Sep 11, 2025

    @dosubot

    Hi @ismaelricopalasios-maker! I'm Dosu and I’m helping the superset team.

    Superset's theming system expects all necessary tokens, like colorText and colorTextSecondary, to be defined in the active theme. There is no fallback logic (such as colorTextSecondary || colorText) implemented in the codebase, and components should not rely on such fallbacks. If a token is missing, the system either uses Ant Design's default or the value is simply absent. This design matches the recommendation to use a single theme color variable for consistent behavior across themes, as relying on fallbacks can cause the kind of visual inconsistencies you described when switching themes. Defining and using only one variable (like theme.colorText) is the intended and most robust approach for consistency across all themes1.

    To reply, just mention @dosu.


    Share context across your team and agents. Try Dosu.

    Leave Feedback Learn about superset with Dosu Add Dosu to your team

    Footnotes

    1. Superset Theme System Source ↩

  2. added
    review:checkpointLast PR reviewed during the daily review standup
    and removed
    review:checkpointLast PR reviewed during the daily review standup
    on Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions