【6.0.0-RC2】Formatting the SQL in the "View Query" pop-up doesn't work #35682

Activity

1. dosubot commented on Oct 16, 2025

   

   dosubotBot

   on Oct 16, 2025 – with DosuBot

   More actions

   This looks like a regression introduced between 6.0.0-RC1 and 6.0.0-RC2. The SQL formatting toggle in the "View Query" pop-up sends a POST request to /api/v1/sqllab/format_sql with a JSON payload containing the SQL string and the database engine. The backend strictly validates this payload and expects a non-empty sql field (string) and, optionally, an engine field (string or null) reference.

   Recent changes to SQL formatting logic and input validation (notably in PRs #30578 and #30350) may have made the backend less tolerant of missing or malformed fields, or changed how the frontend retrieves the engine value reference. If the frontend is sending an undefined or invalid engine, or if the sql field is empty or missing, the backend will return a 400 error.

   To troubleshoot, check the network request payload in your browser's dev tools and confirm both sql and engine are present and valid. If engine is undefined or the SQL is empty, that's likely the cause. This regression is likely due to stricter validation or a frontend change in how the engine is fetched from the dataset metadata.

   To reply, just mention @dosu.

   ---

   ^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}    
2. dosubot

   added

   sqllabNamespace | Anything related to the SQL LabNamespace | Anything related to the SQL Lab

   validation:requiredA committer should validate the issueA committer should validate the issue

   on Oct 16, 2025
3. saghatelian commented on Oct 16, 2025

   

   saghatelian

   on Oct 16, 2025

   Last edited by saghatelian

   ContributorAuthor

   More actions

   Following the steps suggested by @dosu , here are the details of the request:

   Request URL: /api/v1/sqllab/format_sql/

   Payload:

   {
       "sql": "SELECT COUNT(client_id) AS `Signups` \nFROM `dataform_intermediate.clients_extended` \nWHERE `signup_date` >= CAST('2024-10-16T14:24:19.000000' AS TIMESTAMP) AND `signup_date` < CAST('2025-10-17T14:24:19.000000' AS TIMESTAMP)\n LIMIT 50000;",
       "engine": {
           "backend": "bigquery"
       }
   }
   

   Response:

   {
     "message": {
       "engine": [
         "Not a valid string."
       ]
     }
   }
   

   Seems like the error is because the engine is a JSON object {"backend":"bigquery"}, not a string.
4. dosubot commented on Oct 16, 2025

   

   dosubotBot

   on Oct 16, 2025 – with DosuBot

   More actions

   The 400 error happens because the backend expects the engine field to be a string (like "bigquery"), not an object. The correct payload should look like:

   {
     "sql": "SELECT ...",
     "engine": "bigquery"
   }

   This is enforced by the backend schema and confirmed in the frontend code, which should send engine as a string, not as { "backend": "bigquery" } (reference, backend schema). The regression likely comes from a recent frontend change that started passing the whole backend object instead of just the string. Updating the frontend to send only the backend string should resolve the issue.

   To reply, just mention @dosu.

   ---

   ^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}    
5. sadpandajoe

   added this to Apache Superset 6.0.X Release Bugson Oct 21, 2025
6. sadpandajoe

   moved this to New in Apache Superset 6.0.X Release Bugson Oct 21, 2025
7. sadpandajoe

   added a commit that references this issue on Oct 30, 2025

   fix(explore): send database backend as string in View Query format re…

   ...

   This issue will close once commit c93810f is merged into the 'master' branch.

   c93810f
8. sadpandajoe

   self-assigned this

   on Oct 30, 2025
9. sadpandajoe

   moved this from New to In Progress in Apache Superset 6.0.X Release Bugson Oct 30, 2025
10. sadpandajoe

    closed this as completedin #35898on Oct 31, 2025
11. sadpandajoe

    moved this from In Progress to Done in Apache Superset 6.0.X Release Bugson Oct 31, 2025
12. sadpandajoe

    moved this from Done to Cherried in Apache Superset 6.0.X Release Bugson Nov 3, 2025