Select All in a dashboard filter incorrectly displays how many values it is selecting if there are null values

[mason-gordon]

Screenshot

Before clicking "Select All"

After clicking "Select All"

Description

Version: Superset 6.0.0

When selecting values for a dashboard filter, "Select All" does not actually select every displayed value if <NULL> is one of the options. In the screenshots above, you can see that it says Select All (3). When I click on that option, only the 2 "real" values were actually selected. The Deselect All (2) option displays the correct amount of values to deselect.

Design input

I would imagine it's intentional that Select All doesn't select NULL values. I wasn't sure if this was a bug or just an oversight, but if Select All shouldn't select NULL values, then I think Select All should not include it in the total number of options to select. This isn't too challenging to work around on our end, since we can just coalesce the null values into some other placeholder. It is misleading, though, and may affect the experience of dashboard users.

[dosubot]

Hi @mason-gordon! I'm Dosu and I’m helping the superset team.

This looks like a legitimate bug. The issue is a mismatch between how bulkSelectCounts.selectable is calculated versus how handleSelectAll actually selects items.

The count (bulkSelectCounts.selectable) iterates over visibleOptions and counts any option that is not disabled (or is already selected) and is not a new unsaved option — it does not exclude null/falsy values [1].

The selection (handleSelectAll) filters with option.value &&, which excludes null/falsy values from actually being selected [2].

So <NULL> gets counted in the display number but is skipped during actual selection — exactly the behavior you're seeing.

A fix would be to align the two by adding the same falsy-value check to the bulkSelectCounts computation, e.g.:

if (
  option.value &&          // ← add this to match handleSelectAll
  (!isDisabled || isSelected) &&
  ((isNew && isSelected) || !isNew)
) {
  acc.selectable += 1;
}

This is in superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx.

To reply, just mention @dosu.

---

Share context across your team and agents. Try Dosu.

[AoLiGei1221]

Hi Community! I am willing to help with this issue. Please assign to me. Thank you!

[sadpandajoe]

@mason-gordon this looks like correct functionality to me unless if i'm seeing it wrong.

First screenshot:

• 3 options in the dropdown helper text looks right as you have 3 options
• Select all text is right as you would be selecting all 3 options
• Deselect all is correct as you have not selected any options

Second screenshot:

• Tier 1 and Tier 2 have been selected, so you see a 2 in the helper field
• Select all is 3 because there are 3 total items in the list so if you select that you would be selecting all 3 items
• Deselect is correct since you have 2 items selected already, so if you click that it will unselect tier 1 and tier 2

[mason-gordon]

@sadpandajoe this is incorrect

Select all is 3 because there are 3 total items in the list so if you select that you would be selecting all 3 items

The second screenshot is the result of clicking "Select All" - only two items were selected, not 3