Repository navigation
Multiple issues with change_detector.py script #44822
Description
Activity
Both legit! You've already got the right fix in mind for each. Want to open a PR since you're already deep in
change_detector.py, or would you rather this be up for grabs for anyone?Reacted by Đỗ Trọng HảiIt's up for grabs for everyone. Good first issues even :D
I'd like to work on this issue. I'll investigate the current change_detector.py behavior for multi-commit push events and submit a PR with tests.
Hi @hainenber , I'd like to work on this! Can I be assigned?
Hi there! I'd love to take a look at fixing these issues with change_detector.py. Could you please assign this issue to me?
I'd like to pick up the language-classification half of this (the python/frontend directory-group conflation in change_detector.py's PATTERNS, referenced in the review discussion on PR #44699). The push-range half is already in progress in #44833, so I'll leave that alone.
Before I start: on current master, codeql-analysis.yml's analyze job still runs the hardcoded ["python", "javascript"] matrix whenever python == 'true' || frontend == 'true' -- the per-language lang_matrix output that would actually consume a more accurate classification only exists on #44699's branch, which isn't merged yet. So fixing PATTERNS to be language-accurate on master today wouldn't change CodeQL's behavior until #44699 lands (or is rebased onto this).
@hainenber -- is a standalone fix to PATTERNS (making python/frontend classify by file extension/language rather than directory) still useful to land ahead of #44699, or would you rather this be folded into that PR directly once it's further along? Don't want to duplicate work or build something that conflicts with how you're planning to finish #44699.
Go ahead with the lang-classify issue, @kksingh000. Please have your PR independent of my linked PR, i.e keep targeting
main.
Bug description
The script should output changes based on file type, not hybridized between language-specific (
python) and project-specific (frontend). Ref: feat(ci): conditionally run CodeQL analysis workflows only when there are detected JS/Python file changes #44699 (comment)The script should recognize changes within a PR, not the HEAD commit. Ref: feat(ci): conditionally run CodeQL analysis workflows only when there are detected JS/Python file changes #44699 (comment)
Screenshots/recordings
No response
Superset version
master / latest-dev
Python version
3.11
Node version
16
Browser
Chrome
Additional context
No response
Checklist