Repository navigation
fix: unambiguous trino driver - #18683
Merged
Merged
Conversation
betodealmeida
commented
Feb 11, 2022
| entry_points={"console_scripts": ["superset=superset.cli.main:superset"]}, | ||
| entry_points={ | ||
| "console_scripts": ["superset=superset.cli.main:superset"], | ||
| "sqlalchemy.dialects": ["trinonative = sqlalchemy_trino.dialect:TrinoDialect"], |
Member
Author
There was a problem hiding this comment.
Note: this works even if the sqlalchemy-trino library is not installed.
Codecov Report
@@ Coverage Diff @@
## master #18683 +/- ##
==========================================
- Coverage 66.25% 66.19% -0.06%
==========================================
Files 1604 1604
Lines 62807 62808 +1
Branches 6333 6333
==========================================
- Hits 41613 41578 -35
- Misses 19542 19578 +36
Partials 1652 1652
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
approved these changes
Feb 12, 2022
Member
|
Nice! 👍 |
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Both PyHive and
sqlalchemy-trinodeclare atrino://SQLAlchemy dialect. If you create a database in Superset with thetrino://SQLAlchemy URI and have both libraries installed the backend will use one the library randomly on every request, making it impossible to connect to a Trino database.I created a PR upstream renaming the PyHive dialect to
trino+pyhive://(dropbox/PyHive#428), so thattrino://resolves unambiguously. In the meantime, this PR adds atrinonative://entry pointing directly to thesqlalchemy-trinodialect, so that users with both libraries installed can connect to Trino.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
trinonative://scheme.ADDITIONAL INFORMATION