Skip to content

feat(dashboard): add API endpoints for generating and downloading screenshots - #29187

Merged
geido merged 21 commits into
apache:masterfrom
eulloa10:feat--add-dashboard-download-api-endpoint
Jul 8, 2024
Merged

geido merged 21 commits into
apache:masterfrom
eulloa10:feat--add-dashboard-download-api-endpoint

Conversation

@eulloa10

Copy link
Copy Markdown
Contributor

SUMMARY

  1. Dashboard Screenshot Generation:
  • New endpoint computes and caches screenshots based on dashboard state (permalink).
  1. Dashboard Download Endpoint:
  • Added endpoint for downloading dashboard screenshot as PDF or PNG.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions Bot added the api Related to the REST API label Jun 11, 2024
@codecov

codecov Bot commented Jun 11, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 86.07595% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.70%. Comparing base (76d897e) to head (8a0e48d).
Report is 966 commits behind head on master.

Files with missing lines Patch % Lines
superset/tasks/thumbnails.py 15.38% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29187       +/-   ##
===========================================
+ Coverage   60.48%   83.70%   +23.22%     
===========================================
  Files        1931      518     -1413     
  Lines       76236    37722    -38514     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31577    -14537     
+ Misses      28017     6145    -21872     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.86% <45.56%> (-0.30%) ⬇️
javascript ?
mysql 77.27% <86.07%> (?)
postgres 77.37% <86.07%> (?)
presto 53.45% <45.56%> (-0.35%) ⬇️
python 83.70% <86.07%> (+20.22%) ⬆️
sqlite 76.82% <86.07%> (?)
unit 59.15% <45.56%> (+1.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eulloa10 eulloa10 changed the title [WIP] feat(dashboard): add API endpoints for generating and downloading screenshots feat(dashboard): add API endpoints for generating and downloading screenshots Jun 12, 2024
@github-actions github-actions Bot added i18n Namespace | Anything related to localization risk:db-migration PRs that require a DB migration i18n:french Translation related to French language doc Namespace | Anything related to documentation embedded plugins labels Jun 25, 2024
@geido geido reopened this Jun 25, 2024
@github-actions github-actions Bot removed i18n Namespace | Anything related to localization risk:db-migration PRs that require a DB migration i18n:french Translation related to French language doc Namespace | Anything related to documentation embedded plugins dependencies:npm github_actions Pull requests that update GitHub Actions code packages labels Jun 25, 2024
@geido
geido marked this pull request as ready for review June 25, 2024 16:28
@dosubot dosubot Bot added the dashboard:export Related to exporting dashboards label Jun 25, 2024
@john-bodley
john-bodley requested review from eschutho and geido June 25, 2024 17:29
@geido
geido merged commit d896481 into apache:master Jul 8, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
…eenshots (#29187)

Co-authored-by: Diego Pucci <diegopucci.me@gmail.com>
@github-actions github-actions Bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 First shipped in 4.1.0 labels Nov 14, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
…eenshots (apache#29187)

Co-authored-by: Diego Pucci <diegopucci.me@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to the REST API 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:export Related to exporting dashboards size/L 🚢 4.1.0 First shipped in 4.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants