Skip to content

fix(dashboard): overload issue in dashboard export to excel #29418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusackas merged 4 commits into from
Mar 17, 2026
Merged

fix(dashboard): overload issue in dashboard export to excel #29418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35b1902
Fix overload issue during dashboard export to Excel
mcdogg17 Jun 30, 2024
cea2590
Update var name, with pre-commit
mcdogg17 Jan 16, 2025
faab10e
Merge branch 'master' into fix/excel-dashboard-export-overload
rusackas Mar 16, 2026
a9e400d
fix(dashboard): validate current_slice type and guard against key col…
claude Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion superset/common/query_context_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ def __init__(self) -> None:
def create( # pylint: disable=too-many-arguments
self,
*,
current_slice: Slice | None = None,
datasource: DatasourceDict,
queries: list[dict[str, Any]],
form_data: dict[str, Any] | None = None,
Expand All @@ -58,7 +59,9 @@ def create( # pylint: disable=too-many-arguments
datasource_model_instance = self._convert_to_model(datasource)

slice_ = None
if form_data and form_data.get("slice_id") is not None:
if isinstance(current_slice, Slice):
slice_ = current_slice
elif form_data and form_data.get("slice_id") is not None:
slice_ = self._get_slice(form_data.get("slice_id"))

result_type = result_type or ChartDataResultType.FULL
Expand Down
2 changes: 1 addition & 1 deletion superset/models/slice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def get_query_context(self) -> QueryContext | None:
if self.query_context:
try:
return self.get_query_context_factory().create(
**json.loads(self.query_context)
**{**json.loads(self.query_context), "current_slice": self}
)
except json.JSONDecodeError as ex:
logger.error("Malformed json in slice's query context", exc_info=True)
Expand Down
Loading