Repository navigation
fix: Heatmap sorting - #31752
Merged
michael-s-molina merged 1 commit intoJan 9, 2025
Merged
fix: Heatmap sorting#31752
Conversation
Member
Author
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Array index access without bounds check ▹ view | |
|
Unsafe Value Type Assertion in Formatter ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/types.ts | ✅ |
| superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/buildQuery.ts | ✅ |
| superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/transformProps.ts | ✅ |
| superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
| } | ||
| if (sort_y_axis) { | ||
| orderby.push([ | ||
| sort_y_axis.includes('value') ? metric : columns[1], |
There was a problem hiding this comment.
Array index access without bounds check 
Tell me more
What is the issue?
No validation that columns[1] exists before accessing it
Why this matters
If groupby is empty array, columns[1] will be undefined, potentially causing incorrect sorting behavior or runtime errors
Suggested change
Add validation: sort_y_axis.includes('value') ? metric : (columns[1] ?? columns[0])
Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.
Comment on lines
+159
to
+162
| formatter: (params: CallbackDataParams) => { | ||
| const paramsValue = params.value as (string | number)[]; | ||
| return valueFormatter(paramsValue?.[2] as number | null | undefined); | ||
| }, |
There was a problem hiding this comment.
Unsafe Value Type Assertion in Formatter
Tell me more
What is the issue?
The type assertion of params.value to (string | number)[] may lead to runtime errors if the actual value structure differs from the expected format.
Why this matters
If the data structure changes or if params.value is undefined, the code could crash during chart rendering. The current implementation doesn't provide proper runtime validation of the data structure.
Suggested change
Add proper runtime validation:
formatter: (params: CallbackDataParams) => {
if (!params.value || !Array.isArray(params.value)) {
return '';
}
const value = params.value[2];
return valueFormatter(typeof value === 'number' ? value : null);
}Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.
3 tasks done
2 of 3 tasks
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 21, 2025
(cherry picked from commit a477d84)
2 of 3 tasks
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #31318 by giving users the flexibility to sort a Heatmap chart by only one axis.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2025-01-08.at.11.01.26.mov
TESTING INSTRUCTIONS
Check the original issue for instructions.
ADDITIONAL INFORMATION