Repository navigation
fix(superset-ui-core): Include appRoot in endpoint of SupersetClientClass.postForm action - #34395
Merged
rusackas merged 1 commit intoAug 12, 2025
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/packages/superset-ui-core/src/connection/SupersetClientClass.ts | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
All other methods go via SupersetClientClass.request which does this automatically.
martyngigg
force-pushed
the
fix-login-with-non-empty-approot
branch
from
July 30, 2025 09:25
0ab7321 to
8dbfdb3
Compare
martyngigg
requested review from
betodealmeida,
eschutho,
geido,
mistercrunch,
rusackas and
sadpandajoe
as code owners
July 30, 2025 09:25
| await this.ensureAuth(); | ||
| const hiddenForm = document.createElement('form'); | ||
| hiddenForm.action = url; | ||
| hiddenForm.action = this.getUrl({ endpoint }); |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML
2 of 3 tasks
rusackas
approved these changes
Aug 12, 2025
rusackas
left a comment
rusackas
left a comment
Member
There was a problem hiding this comment.
LGTM (and Claude and RooCode)
LisaHusband
pushed a commit
to LisaHusband/superset
that referenced
this pull request
Aug 17, 2025
…lass.postForm action (apache#34395)
3 tasks done
3 tasks
3 tasks done
Closed
3 tasks done
github-actions
Bot
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…lass.postForm action (apache#34395)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
SupersetClientClass.request uses
SupersetClientClass.getUrlto construct the correct endpoint, including an optionalappRootif set.SupersetClientClass.postForm used the
urlas passed to it and subsequently failed ifappRootis not empty.With this change
postFormalso usesgetUrlto ensure the appropriate endpoint is created.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
This can be verified using the docker compose development setup.
Set a non-empty root:
Bring up the light docker compose config:
When the frontend has finished building go to http://localhost:9001/prefix and login with "admin:admin". Before these changes the successful login would redirect to http://localhost:9001/login rather than http://localhost:9001/prefix/login.
ADDITIONAL INFORMATION