Repository navigation
fix(theming): Visual bugs p-3 - #34424
Merged
Merged
Conversation
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
msyavuz
marked this pull request as ready for review
July 31, 2025 14:18
dosubot
Bot
added
change:frontend
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Hardcoded Style Value ▹ view | 🧠 Not in standard |
 |
Missing Virtualization for Large Control Lists ▹ view | 🧠 Not in standard |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/explore/components/controls/DateFilterControl/components/DateLabel.tsx | ✅ |
| superset-frontend/src/components/Chart/MenuItemWithTruncation.tsx | ✅ |
| superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.tsx | ✅ |
| superset-frontend/src/explore/components/ControlPanelsContainer.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
+123
to
+125
| css={css` | ||
| max-width: 200px; | ||
| `} |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
142
to
145
| #controlSections { | ||
| height: 100%; | ||
| overflow: visible; | ||
| padding-bottom: ${({ theme }) => theme.sizeUnit * 10}px; | ||
| flex: 1; | ||
| overflow: auto; | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
msyavuz
requested review from
betodealmeida,
eschutho,
geido,
mistercrunch,
rusackas and
sadpandajoe
as code owners
July 31, 2025 20:21
LisaHusband
pushed a commit
to LisaHusband/superset
that referenced
this pull request
Aug 17, 2025
2 of 3 tasks
github-actions
Bot
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix visual bugs and issues leftover from theming
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Time filter:
Before:
After:
Explore Control Panels overlap:
Before:
After:
Drill to detail by by overflow:
Before:
After:
Drill by hover:
Before:
After:
TESTING INSTRUCTIONS
Check listed visuals to confirm, run the testing suite
ADDITIONAL INFORMATION