Skip to content

fix(RightMenu): Ensure links in RightMenu contains app root when applicable - #36054

Closed
martyngigg wants to merge 2 commits into
apache:masterfrom
ISISNeutronMuon:fix-rightmenu-userinfo-link
Closed

fix(RightMenu): Ensure links in RightMenu contains app root when applicable#36054
martyngigg wants to merge 2 commits into
apache:masterfrom
ISISNeutronMuon:fix-rightmenu-userinfo-link

Conversation

@martyngigg

@martyngigg martyngigg commented Nov 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

SUMMARY

Fixes for the settings menu:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Refs #35027

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review

bito-code-review Bot commented Nov 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Agent Run #54425d

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 652c52b..652c52b
    • superset-frontend/src/features/home/RightMenu.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot Bot added the change:frontend Requires changing the frontend label Nov 10, 2025
korbit-ai[bot]
korbit-ai Bot suggested changes Nov 10, 2025
View reviewed changes

@korbit-ai korbit-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Status
Functionality Missing null check before ensureAppRoot call ▹ view
Files scanned ​
File Path Reviewed
superset-frontend/src/features/home/RightMenu.tsx ✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Comment thread superset-frontend/src/features/home/RightMenu.tsx
@martyngigg martyngigg mentioned this pull request Nov 10, 2025
Closed
3 tasks done
@martyngigg martyngigg changed the title fix(RightMenu): Ensure User Info link in RightMenu contains app root fix(RightMenu): Ensure links in RightMenu contains app root when applicable Nov 10, 2025
@martyngigg
Remove old fab_override template references
56b136d 
The superset/fab_override templates no longer exist but
were still referenced. Remove the override classes that
reference them and fallback to the FAB templates.
@codecov

codecov Bot commented Nov 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.70%. Comparing base (c42e3c6) to head (56b136d).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #36054       +/-   ##
===========================================
+ Coverage        0   68.70%   +68.70%     
===========================================
  Files           0      622      +622     
  Lines           0    45738    +45738     
  Branches        0     4978     +4978     
===========================================
+ Hits            0    31426    +31426     
- Misses          0    13066    +13066     
- Partials        0     1246     +1246
Flag Coverage Δ
hive 44.16% <ø> (?)
mysql 67.78% <ø> (?)
postgres 67.83% <ø> (?)
presto 47.71% <ø> (?)
python 68.67% <ø> (?)
sqlite 67.45% <ø> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martyngigg

martyngigg commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

Closing this in favour of wider changes to fix app root issues.

@martyngigg martyngigg closed this Nov 10, 2025
@dosubot dosubot Bot mentioned this pull request Nov 17, 2025
Closed
3 tasks done
@martyngigg
martyngigg deleted the fix-rightmenu-userinfo-link branch December 9, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@korbit-ai korbit-ai[bot] korbit-ai[bot] requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

change:frontend Requires changing the frontend size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@martyngigg