Skip to content

fix: UI cut off - #36531

Merged
geido merged 1 commit into
masterfrom
enxdev/fix/ui-cut-off
Dec 22, 2025
Merged

fix: UI cut off#36531
geido merged 1 commit into
masterfrom
enxdev/fix/ui-cut-off

Conversation

@EnxDev

@EnxDev EnxDev commented Dec 11, 2025 •
edited by geido
Loading

Copy link
Copy Markdown
Contributor

SUMMARY

Addressed some styling issues in Explore where some parts were clipped off. Updated line-height from 1/1em to 1.5 for text elements to allow descenders. Added overflow: visible and height: auto to prevent container clipping. Added padding-bottom and vertical-align adjustments for Firefox compatibility.

BEFORE

518656450-1bb59a88-84b9-4eb1-a22f-27b7f3b77412

AFTER

518656589-b08a9bde-7d78-4279-b724-c0691f16b4d3

TESTING INSTRUCTIONS

Browse the UI to ensure no visual elements are cut off

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review

bito-code-review Bot commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at evan@preset.io.

@geido
geido marked this pull request as ready for review December 11, 2025 16:59
@geido geido added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Dec 11, 2025
@dosubot dosubot Bot added change:frontend Requires changing the frontend explore:design Related to the Explore UI/UX labels Dec 11, 2025
@github-actions github-actions Bot added 🎪 d71f04b 🚦 building and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Dec 11, 2025
@github-actions

github-actions Bot commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

🎪 Showtime is building environment on GHA for d71f04b

@github-actions

github-actions Bot commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

🎪 Showtime deployed environment on GHA for d71f04b

• Environment: http://54.203.129.254:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

@rusackas
rusackas requested a review from justinpark December 15, 2025 18:26
@geido
geido merged commit 32c98d0 into master Dec 22, 2025
137 of 139 checks passed
@geido
geido deleted the enxdev/fix/ui-cut-off branch December 22, 2025 14:52
sadpandajoe pushed a commit that referenced this pull request Dec 29, 2025
@EnxDev @geido @sadpandajoe
fix: UI cut off (#36531)
7a9741d 
Co-authored-by: Diego Pucci <diegopucci.me@gmail.com>
(cherry picked from commit 32c98d0)
@sadpandajoe sadpandajoe added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Dec 29, 2025
sadpandajoe pushed a commit that referenced this pull request Dec 29, 2025
@EnxDev @geido @sadpandajoe
fix: UI cut off (#36531)
9ee59fc 
Co-authored-by: Diego Pucci <diegopucci.me@gmail.com>
(cherry picked from commit 32c98d0)
sadpandajoe pushed a commit that referenced this pull request Dec 29, 2025
@EnxDev @geido @sadpandajoe
fix: UI cut off (#36531)
3b15ff3 
Co-authored-by: Diego Pucci <diegopucci.me@gmail.com>
(cherry picked from commit 32c98d0)
@dosubot dosubot Bot mentioned this pull request Jan 20, 2026
Closed
isaac-jaynes-imperva pushed a commit to isaac-jaynes-imperva/superset that referenced this pull request Mar 3, 2026
@EnxDev @geido Joey Andres
fix: UI cut off (apache#36531)
851620e 
Co-authored-by: Diego Pucci <diegopucci.me@gmail.com>
(cherry picked from commit 32c98d0)
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
@EnxDev @geido
fix: UI cut off (apache#36531)
f0bd086 
Co-authored-by: Diego Pucci <diegopucci.me@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geido geido geido approved these changes
@justinpark justinpark Awaiting requested review from justinpark

Assignees

No one assigned

Labels

change:frontend Requires changing the frontend explore:design Related to the Explore UI/UX size/S v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EnxDev @geido @sadpandajoe