feat(mcp): dynamic feature availability via menus and feature flags by aminghadersohi · Pull Request #37964 · apache/superset

aminghadersohi · 2026-02-13T16:09:31Z

SUMMARY

When the MCP service can't answer a user's question via available tools, LLMs fall back to suggesting UI features that may not exist in a given deployment. This misleads users.

This PR adds dynamic feature detection to get_instance_info so LLMs know what's actually available at request time:

get_instance_info now returns a feature_availability section containing accessible_menus — the menu items the current user can access (via security_manager.user_view_menu_names("menu_access"))
MCP instructions now direct LLMs to call get_instance_info for feature availability instead of assuming what exists

Why dynamic? Menus already track what's available per-user and per-deployment via FAB role permissions. Querying them at request time means feature availability stays in sync automatically — no manual configuration needed.

Example `get_instance_info` response (truncated)

{
  "instance_summary": { "total_dashboards": 0, "total_charts": 0, "total_datasets": 15, ... },
  "current_user": { "id": 1, "username": "admin", "first_name": "Admin I.", ... },
  "feature_availability": {
    "accessible_menus": [
      "Action Log", "Alerts & Report", "Annotation Layers", "CSS Templates",
      "Charts", "Dashboards", "Data", "Databases", "Datasets", "Extensions",
      "Home", "List Groups", "List Roles", "List Users", "Manage", "Plugins",
      "Query Search", "Row Level Security", "SQL Editor", "SQL Lab",
      "Saved Queries", "Security", "Tags", "Tasks", "Themes", "User Registrations"
    ]
  },
  "timestamp": "2026-02-24T18:23:43.927486Z"
}

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A - backend change, no UI impact

TESTING INSTRUCTIONS

Automated Tests

pytest tests/unit_tests/mcp_service/test_mcp_config.py tests/unit_tests/mcp_service/system/test_system_utils.py -x -v

QA Manual Testing Steps

Test 1: Feature availability in get_instance_info

Connect an MCP client and call get_instance_info
Expected: Response includes feature_availability with accessible_menus populated from the user's FAB permissions

Test 2: Per-user menu access

Connect as a user with limited roles (e.g., Gamma)
Call get_instance_info
Expected: accessible_menus only contains menus the user has menu_access permission for — admin-only menus should not appear

Test 3: Instructions reference get_instance_info

Inspect the MCP server instructions
Expected: Instructions mention "Feature Availability" and direct LLMs to call get_instance_info for accessible menus

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

bito-code-review · 2026-02-13T16:09:42Z

Code Review Agent Run #8dd73a

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 427ba68..427ba68
- superset/mcp_service/app.py
- superset/mcp_service/mcp_config.py
- tests/unit_tests/mcp_service/test_mcp_config.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codecov · 2026-02-13T16:19:28Z

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.38%. Comparing base (7b04d25) to head (69b69a0).
⚠️ Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/mcp_service/system/system_utils.py	0.00%	11 Missing ⚠️
superset/mcp_service/system/schemas.py	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #37964       +/-   ##
===========================================
+ Coverage        0   66.38%   +66.38%     
===========================================
  Files           0      670      +670     
  Lines           0    51469    +51469     
  Branches        0     5810     +5810     
===========================================
+ Hits            0    34169    +34169     
- Misses          0    15905    +15905     
- Partials        0     1395     +1395

Flag	Coverage Δ
hive	`41.40% <0.00%> (?)`
mysql	`64.49% <0.00%> (?)`
postgres	`64.57% <0.00%> (?)`
presto	`41.42% <0.00%> (?)`
python	`66.36% <0.00%> (?)`
sqlite	`64.16% <0.00%> (?)`
unit	`100.00% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

netlify · 2026-02-13T17:31:25Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`b0ed63c`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/699dd9180611a2000910a9de
😎 Deploy Preview	https://deploy-preview-37964--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

bito-code-review · 2026-02-13T17:44:15Z

Code Review Agent Run #590807

Actionable Suggestions - 0

Additional Suggestions - 1

tests/unit_tests/mcp_service/test_mcp_config.py - 1
- Docstring mismatch · Line 183-183
  
  The docstring appears inconsistent with the test function name and the actual code being tested, which calls `init_fastmcp_server()`. It looks like this might be an oversight in the change.
  Code suggestion
  @@ -183,1 +183,1 @@ - """Test that init reads MCP_UNAVAILABLE_FEATURES from Flask config.""" + """Test that init_fastmcp_server reads MCP_UNAVAILABLE_FEATURES from Flask config."""

Review Details

Files reviewed - 3 · Commit Range: 427ba68..15d10f0
- superset/mcp_service/app.py
- superset/mcp_service/mcp_config.py
- tests/unit_tests/mcp_service/test_mcp_config.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-02-20T11:05:39Z

The features in unavailable_features are arbitrary strings not tied to tool names, as you noted. By default, there's no exhaustive list; it's configurable via MCP_UNAVAILABLE_FEATURES in the config, with an example like ["Action Log (Settings > Security > Action Log)", "List Users page"]. To make it easier, consider adding a documented list of all possible features in the config file or README, based on Superset's UI elements.

bito-code-review · 2026-02-20T16:22:55Z

Code Review Agent Run #9642bb

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 15d10f0..266d14d
- superset/mcp_service/app.py
- superset/mcp_service/mcp_config.py
- tests/unit_tests/mcp_service/test_mcp_config.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

…c warnings When the MCP service can't answer a user's question via available tools, LLMs may suggest Superset UI features that don't exist in all deployments (e.g., Action Log, List Users in Preset). This adds a configurable list that gets injected into MCP instructions so LLMs know not to suggest them.

Add MCP_FEATURE_ACTION_LOG, MCP_FEATURE_LIST_USERS, MCP_FEATURE_LIST_ROLES constants and MCP_ALL_KNOWN_FEATURES convenience list so deployers can reference well-known features instead of guessing string values. Addresses review feedback requesting a standard way to discover available feature names for the config. Also fixes test docstring line-length violation (E501).

…tion Instead of maintaining a static list of MCP_FEATURE_* constants that operators must manually keep in sync, dynamically detect feature availability at request time by querying: - FAB security manager for accessible menus (user_view_menu_names) - Feature flag manager for enabled/disabled flags (get_feature_flags) - MCP_UNAVAILABLE_FEATURES as a minimal escape hatch for custom notes The get_instance_info tool now returns a feature_availability section with accessible_menus, enabled_feature_flags, and custom_unavailable_features, giving LLMs accurate per-user context without stale hardcoded lists.

Dynamic detection via menus and feature flags makes this config redundant. No reason to keep a static escape hatch when the same information is already available from existing systems.

bito-code-review · 2026-02-24T17:55:17Z

Code Review Agent Run #b128d6

Actionable Suggestions - 0

Review Details

Files reviewed - 7 · Commit Range: 999ffae..3000b33
- superset/mcp_service/app.py
- superset/mcp_service/system/schemas.py
- superset/mcp_service/system/system_utils.py
- superset/mcp_service/system/tool/get_instance_info.py
- tests/unit_tests/mcp_service/system/test_system_utils.py
- tests/unit_tests/mcp_service/system/tool/test_get_current_user.py
- tests/unit_tests/mcp_service/test_mcp_config.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

Only expose accessible_menus — feature flags are internal implementation details that add noise and potential security surface area.

bito-code-review · 2026-02-24T19:33:07Z

Code Review Agent Run #f1d8c0

Actionable Suggestions - 0

Review Details

Files reviewed - 7 · Commit Range: 3000b33..69b69a0
- superset/mcp_service/app.py
- superset/mcp_service/system/schemas.py
- superset/mcp_service/system/system_utils.py
- superset/mcp_service/system/tool/get_instance_info.py
- tests/unit_tests/mcp_service/system/test_system_utils.py
- tests/unit_tests/mcp_service/system/tool/test_get_current_user.py
- tests/unit_tests/mcp_service/test_mcp_config.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

…pache#37964) (cherry picked from commit 1cd35bb)

…pache#37964)

pull-request-size Bot added the size/M label Feb 13, 2026

dosubot Bot added the change:backend Requires changing the backend label Feb 13, 2026

Antonio-RiveroMartnez reviewed Feb 20, 2026

View reviewed changes

Comment thread superset/mcp_service/app.py Outdated

pull-request-size Bot added size/L and removed size/M labels Feb 20, 2026

aminghadersohi requested a review from Antonio-RiveroMartnez February 20, 2026 21:45

Antonio-RiveroMartnez reviewed Feb 24, 2026

View reviewed changes

Comment thread superset/mcp_service/mcp_config.py Outdated

Comment thread superset/mcp_service/mcp_config.py Outdated

Comment thread superset/mcp_service/mcp_config.py Outdated

aminghadersohi added 5 commits February 24, 2026 11:58

fix(mcp): shorten docstring to fix E501 line too long

e6c1128

ci: retrigger CI for flaky test-sqlite timing assertion

242ec25

aminghadersohi force-pushed the amin/mcp-unavailable-features-warning branch from 8921e1e to b0ed63c Compare February 24, 2026 17:00

aminghadersohi added 3 commits February 24, 2026 12:07

refactor(mcp): remove MCP_UNAVAILABLE_FEATURES config entirely

5e20475

Dynamic detection via menus and feature flags makes this config redundant. No reason to keep a static escape hatch when the same information is already available from existing systems.

style(mcp): revert unnecessary signature reformatting

fd3dd3c

fix(mcp): add feature_availability to test helper for InstanceInfo

3000b33

aminghadersohi requested a review from Antonio-RiveroMartnez February 24, 2026 17:43

aminghadersohi changed the title ~~feat(mcp): add MCP_UNAVAILABLE_FEATURES config for deployment-specific warnings~~ feat(mcp): dynamic feature availability via menus and feature flags Feb 24, 2026

refactor(mcp): remove feature flags from feature_availability response

69b69a0

Only expose accessible_menus — feature flags are internal implementation details that add noise and potential security surface area.

Antonio-RiveroMartnez approved these changes Feb 25, 2026

View reviewed changes

Antonio-RiveroMartnez merged commit 1cd35bb into apache:master Feb 25, 2026
67 checks passed

aminghadersohi added a commit to preset-io/superset that referenced this pull request Mar 13, 2026

feat(mcp): dynamic feature availability via menus and feature flags (a…

2c0dc0a

…pache#37964) (cherry picked from commit 1cd35bb)

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

feat(mcp): dynamic feature availability via menus and feature flags (a…

d90241b

…pache#37964)

aminghadersohi mentioned this pull request Oct 2, 2026

fix(mcp): include feature_availability in instance://metadata resource #44891

Merged

9 tasks

Conversation

aminghadersohi commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

Example get_instance_info response (truncated)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Automated Tests

QA Manual Testing Steps

ADDITIONAL INFORMATION

Uh oh!

bito-code-review Bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #8dd73a

Uh oh!

codecov Bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

netlify Bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

bito-code-review Bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #590807

Uh oh!

Uh oh!

bito-code-review Bot commented Feb 20, 2026

Uh oh!

bito-code-review Bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #9642bb

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bito-code-review Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #b128d6

Uh oh!

bito-code-review Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #f1d8c0

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aminghadersohi commented Feb 13, 2026 •

edited

Loading

Example `get_instance_info` response (truncated)

bito-code-review Bot commented Feb 13, 2026 •

edited

Loading

codecov Bot commented Feb 13, 2026 •

edited

Loading

netlify Bot commented Feb 13, 2026 •

edited

Loading

bito-code-review Bot commented Feb 13, 2026 •

edited

Loading

bito-code-review Bot commented Feb 20, 2026 •

edited

Loading

bito-code-review Bot commented Feb 24, 2026 •

edited

Loading

bito-code-review Bot commented Feb 24, 2026 •

edited

Loading