Skip to content

chore(i18n): update German (de) translation - #40431

Merged
rusackas merged 7 commits into
apache:masterfrom
timitos:timitos/i18n-de
Jun 17, 2026
Merged

rusackas merged 7 commits into
apache:masterfrom
timitos:timitos/i18n-de

Conversation

@timitos

@timitos timitos commented May 26, 2026

Copy link
Copy Markdown
Contributor

SUMMARY

Updates the German (de) translation file (superset/translations/de/LC_MESSAGES/messages.po).

The existing translation was partially outdated and contained many fuzzy/untranslated entries. This commit refreshes the .po file to align with the current message catalog, removing stale entries and providing accurate German translations for the current UI strings.

TESTING INSTRUCTIONS

  1. Build Superset with LANGUAGES = {"de": {"flag": "de", "name": "German"}} set in superset_config.py
  2. Switch the UI language to German in the user settings
  3. Verify that previously missing or untranslated strings now appear in German
  4. No regressions expected for other locales

ADDITIONAL INFORMATION

  • Required feature flags: none
  • API changes: none
  • DB migration required: no

@timitos
timitos requested review from rusackas and sfirke as code owners May 26, 2026 10:18
@dosubot dosubot Bot added the i18n:german Translation related to German language label May 26, 2026
@bito-code-review

bito-code-review Bot commented May 26, 2026 •

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.

@github-actions github-actions Bot added the i18n Namespace | Anything related to localization label May 26, 2026
Comment thread superset/translations/de/LC_MESSAGES/messages.po
@bito-code-review

Copy link
Copy Markdown
Contributor

The provided pr_comments.csv file appears to be empty or incomplete, as it only contains a header row and no actual comment data. Without the content of the file, I cannot validate the correctness of the flagged issue or provide a resolution. Please ensure the file contains the expected review comments for further analysis.

@timitos

timitos commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

My main concern right now is that I don’t understand why Datensatz was replaced with Dataset.

Datensatz is ambiguous in the BI context. There are two words that can be translated as Datensatz: Record and Dataset. I did some research and found that many BI tools keep 'Dataset' untranslated. This prevents ambiguity.

@timitos

timitos commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Datensatz is ambiguous in the BI context. There are two words that can be translated as Datensatz: Record and Dataset. I did some research and found that many BI tools keep 'Dataset' untranslated. This prevents ambiguity.

Superset is not exclusively used in the BI context. It is a general purpose data exploration and visualization platform. In my opinion it should stay Datensatz 🤔

So how should "Record" be translated then?

@timitos

timitos commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

So how should "Record" be translated then?

Maybe Eintrag could work, what do you think?

Yes — since entry only occurs once in the source strings, there's no real risk of overloading the term, so Eintrag for record seems viable.

I made the switch to Datensatz for Dataset coming from a more technical / BI background, but I can fully understand your perspective coming from an academic / research background. There are essentially two worlds using the same tool with different preferred vocabularies, and I doubt we can fully satisfy both. It's a genuinely difficult call.

How does the project usually resolve cases like this — is there a translation glossary or a maintainer preference we should follow? I'm happy to go either way as long as we apply it consistently (e.g. record → Eintrag to avoid the clash).

@rusackas

rusackas commented Jun 1, 2026

Copy link
Copy Markdown
Member

Looks like this needs conflicts resolved... some files were just brought up to speed on master.

@timitos

timitos commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

@timitos Do you want to follow up on this? A rebase is needed and some merge conflicts might need to be resolved.

If you don't want to continue, I'm happy to take over for you. Just give me a short headsup 🙃

@semohr i am on it. just give me some time.

@timitos
timitos force-pushed the timitos/i18n-de branch from e70da1c to 06c6dae Compare June 9, 2026 17:55
@timitos
timitos force-pushed the timitos/i18n-de branch from 06c6dae to d7b92c3 Compare June 9, 2026 18:05
@netlify

netlify Bot commented Jun 9, 2026

Copy link
Copy Markdown

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 06c6dae
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a28537fade4e80008a85dd2
😎 Deploy Preview https://deploy-preview-40431--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 9, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 9c82a9c
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a302e088d95e00008b1c156
😎 Deploy Preview https://deploy-preview-40431--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jun 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.01%. Comparing base (a1bc3c6) to head (a1b2a29).
⚠️ Report is 51 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #40431      +/-   ##
==========================================
- Coverage   64.28%   64.01%   -0.27%     
==========================================
  Files        2660     2658       -2     
  Lines      144701   144332     -369     
  Branches    33370    33244     -126     
==========================================
- Hits        93016    92391     -625     
- Misses      50037    50288     +251     
- Partials     1648     1653       +5     
Flag Coverage Δ
hive 39.35% <ø> (-0.03%) ⬇️
mysql 58.07% <ø> (-0.04%) ⬇️
postgres 58.13% <ø> (-0.04%) ⬇️
presto 40.92% <ø> (-0.03%) ⬇️
python 59.59% <ø> (-0.04%) ⬇️
sqlite 57.76% <ø> (-0.04%) ⬇️
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rusackas

Copy link
Copy Markdown
Member

Did my best to resolve the conflicts. Hoping CI passes.

Comment thread superset/translations/de/LC_MESSAGES/messages.po Outdated
Comment thread superset/translations/de/LC_MESSAGES/messages.po Outdated
Comment thread superset/translations/de/LC_MESSAGES/messages.po Outdated
Comment thread superset/translations/de/LC_MESSAGES/messages.po Outdated
Two German entries had msgstr ending in \n while the source msgid ended
with a trailing whitespace-only line, so msgfmt rejected the catalog and
check_translation_regression.py failed (babel-extract). Mirror the msgid
trailing line in each msgstr so both sides match.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@rusackas

Copy link
Copy Markdown
Member

Pushed a small fix on top, @timitos — the de catalog had two entries where the msgstr ended with \n but the source msgid ended with a trailing-whitespace line, which made msgfmt reject the whole catalog and failed the translation-regression check. Mirrored the source's trailing line in both. Should be green now. Thanks for the German updates!

@rusackas rusackas added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Jun 16, 2026
…ght, time columns)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@rusackas
rusackas merged commit 2ea7585 into apache:master Jun 17, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n:german Translation related to German language i18n Namespace | Anything related to localization merge-if-green If approved and tests are green, please go ahead and merge it for me size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants