Repository navigation
fix(explore): prevent duplicate Date Range tooltips - #43425
Conversation
dosubot
Bot
added
change:frontend
Code Review Agent Run #fec59bActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
|
The flagged issue is correct. The Here is a concise fix using a <button
type="button"
data-test={`${name}-description-icon`}
onMouseEnter={() => onDescriptionHoverChange?.(true)}
onMouseLeave={() => onDescriptionHoverChange?.(false)}
onClick={tooltipOnClick}
css={css`
background: none;
border: none;
padding: 0;
cursor: pointer;
`}
aria-label={t('Show info tooltip')}
>
<Tooltip
id="description-tooltip"
title={description}
placement="top"
mouseLeaveDelay={0}
>
<Icons.InfoCircleOutlined css={iconStyles} />
</Tooltip>{' '}
</button>Would you like me to check the rest of the comments on this PR and implement fixes for them as well? superset-frontend/src/explore/components/ControlHeader.tsx |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43425 +/- ##
==========================================
+ Coverage 78.93% 78.94% +0.01%
==========================================
Files 2877 2877
Lines 165232 165255 +23
Branches 38184 38192 +8
==========================================
+ Hits 130418 130461 +43
+ Misses 32352 32332 -20
Partials 2462 2462
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
please see the changes i made and tell if there is any problem with the changes |
Code Review Agent Run #f73e30Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
/review full |
Code Review Agent Run #07b825Actionable Suggestions - 0Additional Suggestions - 1
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
/review full |
Code Review Agent Run #8a6a2eActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
everything is done , please suggest some fix if needed |
Code Review Agent Run #5d2498Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
/resolve |
|
Hi maintainers — I’ve addressed all current review feedback, including keyboard accessibility for the info icon and focused regression tests for the ControlHeader hover/keyboard behavior and Date Range tooltip suppression. The latest full reviews report no actionable suggestions. The remaining required checks are red because their upstream jobs were cancelled before the test steps ran (the required jobs report RESULT=cancelled), not because of a test failure. Contributor reruns are blocked with a repository-admin permission error. Could a maintainer please approve and rerun the workflows? Thank you! |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/review full |
Code Review Agent Run #f70230Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
Hi maintainers, it looks like the remaining frontend CI failure is unrelated to this PR. The sharded-jest-tests (3) job passed 1,394 tests and failed only SqlEditor.test.tsx because JSDOM couldn’t parse an auto-generated Ant Design/Emotion CSS selector. I tried rerunning the failed shard, but contributors don’t have permission to rerun workflow jobs in this repository. Could someone with access please rerun sharded-jest-tests (3) when convenient? Thanks! |
Code Review Agent Run #cd2a41Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
Retarted the failing CI job. 🤞 |
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
LGTM. Both threads hold up when I trace the actual diff, the icon now mirrors the same role="button" pattern already used for the label text a few lines down, and focus/blur drive the same suppression callback as mouse enter/leave, plus trigger={['hover', 'focus']} so the description tooltip actually responds to keyboard focus in the first place. DateFilterLabel.test.tsx's new test walks the full hover/focus/blur/unhover sequence asserting only one tooltip at a time, which is exactly the bug here. Just waiting on sharded-jest-tests (3), everything else is green.
Control.tsx only set hovered from mouse enter/leave, so tabbing into Date Range never mounted the info icon. Track hover and focus separately and pass hovered or focused so the icon is reachable from the keyboard.
Code Review Agent Run #1306d6Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
|
Co-authored-by: Joe Li <joe@preset.io>
SUMMARY
Hovering the Date Range info icon in Explore currently opens two tooltips at once: the control description and the resolved time-range tooltip on the field.
The info icon lives in
ControlHeaderand is absolutely positioned next to the label. The Date Range value is wrapped in its own tooltip inDateFilterLabel. Those two hover targets can overlap, so both tooltips fire together.This keeps both tooltips. The field tooltip is suppressed only while the info icon is hovered, the icon stacking is isolated from the field, and the field tooltip closes immediately on mouse leave. Hovering the Date Range field still shows the time-range tooltip.
Fixes #43386
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before — hovering the info icon shows two tooltips:
After — hovering the info icon shows only the description tooltip:
After — hovering the Date Range field still shows the field tooltip:
TESTING INSTRUCTIONS
docker compose up --buildor your usual setup).iicon next to the Date Range label.Unit coverage is in
DateFilterLabel.test.tsx: it hovers the field, then the info icon, and asserts only one tooltip is shown.ADDITIONAL INFORMATION