Skip to content

chore(api): regenerate the spec for ReportScheduleRestApi.report_format - #43910

Merged
villebro merged 1 commit into
apache:masterfrom
shivamgoel:fix/regenerate-spec-report-format
Sep 4, 2026
Merged

villebro merged 1 commit into
apache:masterfrom
shivamgoel:fix/regenerate-spec-report-format

Conversation

@shivamgoel

Copy link
Copy Markdown
Contributor

SUMMARY

Unblocks the API staleness check on master. #43365 added report_format to ReportScheduleRestApi's list columns without regenerating openapi.json, so ReportScheduleRestApi.get_list is missing the field.

The check was already on master when #43365 merged, but that PR's last CI run predated it and GitHub does not re-run workflows at merge time, so the check never reported there. Any PR whose latest run predates #43841 can still land stale this way; enabling "require branches to be up to date before merging" for the check would close it, otherwise it self-heals as open PRs rebase.

TESTING INSTRUCTIONS

SUPERSET__SQLALCHEMY_DATABASE_URI='sqlite:///:memory:' \
  FLASK_APP='superset.app:create_app()' superset update-api-docs
git diff --stat -- docs/static/resources/openapi.json   # clean with this PR

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
  • Introduces new feature or API
  • Removes existing feature or API

apache#43365 added report_format to the report schedule list columns without
regenerating, so the API staleness check fails on master.
@bito-code-review

bito-code-review Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@github-actions github-actions Bot added the doc Namespace | Anything related to documentation label Sep 4, 2026
@netlify

netlify Bot commented Sep 4, 2026

Copy link
Copy Markdown

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit d9392e3
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a9b4bcb5ad81b0008817b56
😎 Deploy Preview https://deploy-preview-43910--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@villebro
villebro merged commit 724d904 into apache:master Sep 4, 2026
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Namespace | Anything related to documentation size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants