Repository navigation
chore(deps): bump sqlglot from 30.17.0 to 30.18.0 - #44192
Conversation
Bumps [sqlglot](https://github.com/tobymao/sqlglot) from 30.17.0 to 30.18.0. - [Commits](tobymao/sqlglot@v30.17.0...v30.18.0) --- updated-dependencies: - dependency-name: sqlglot dependency-version: 30.18.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependabot
minor
Code Review Agent Run #0d4b2cActionable Suggestions - 0Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #44192 +/- ##
=======================================
Coverage 80.16% 80.17%
=======================================
Files 2925 2925
Lines 172563 172648 +85
Branches 40058 40076 +18
=======================================
+ Hits 138339 138422 +83
- Misses 31627 31629 +2
Partials 2597 2597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Code Review Agent Run #e95240Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
…al change sqlglot 30.18.0 renamed exp.Drop's `this` arg to `tables` (a list), breaking the StarRocks dialect's custom DROP parser. It also made `traverse_scope` raise `OptimizeError` instead of skipping a set-operation operand it can't build a scope for (e.g. a bare predicate like `1 = 1` in `1 = 1 UNION ALL SELECT ...`), which broke table extraction for any such statement. Co-Authored-By: Evan Rusackas <evan@preset.io> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Code Review Agent Run #bcd2e4Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
…fallback dead sqlglot 30.18 now intercepts a bare column-level `KEY` attribute before dispatching to the dialect's CONSTRAINT_PARSERS override, so the unnamed-fallback branch in _parse_starrocks_key_constraint is no longer reachable through any known SQL construct. Adds a test for the still-live `KEY <name> (...)` inline index form and marks the now-dead fallback `pragma: no cover` to restore the 100% coverage gate. Co-Authored-By: Evan Rusackas <evan@preset.io> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Code Review Agent Run #280a3bActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
Green across the board, minor sqlglot bump. Approving.
sqlglot 30.18.0 passes a ``parse_mod`` keyword to ``Parser._parse_term``, which 7.0's DB2 dialect overrides without that argument. Under 30.18+ every DB2 statement with LIMIT/OFFSET raises ``TypeError: DB2.Parser._parse_term() got an unexpected keyword argument 'parse_mod'``, and Superset applies a LIMIT to nearly every query. The locked requirements pin 30.17.0, so Docker images were unaffected, but pip installs resolved the newest release the ``<31`` range allowed. On master the DB2 override was adapted (#44708) together with the sqlglot 30.18/30.19 bumps (#44192, #44935); 7.0 keeps 30.17 instead.
1 participant
Bumps sqlglot from 30.17.0 to 30.18.0.
Commits
2e86dedfeat(teradata):mod()func syntax9ea78d0Clean up mod patch2391144fix(postgres): keep the time zone argument of DATE_TRUNC [CLAUDE] (#8305)3128980Sync w/ integration testsb3f23fefix(generator)!: mod generation precedence (#8290)1fa9653perf(dialects): cache dialect classes resolved through the package _getattr...e1fa30dSync w/ integration testsbb6220bfix(snowflake)!: stop dropping structured types on CREATE TABLE [GROK] (#8299)c6c1fa4fix(transforms): keep the table when dropping an unnamed UNIQUE constraint [C...d546830fix(spark): distinguish GROUPING SETS suffix syntax (#8288)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)