Repository navigation
fix(migrations): merge theme editors and purge audit heads - #44364
Conversation
master has two alembic heads, so `superset db upgrade` aborts with "Multiple head revisions are present" and every PR's integration CI legs fail in 1-2 minutes before running any tests. Add an empty merge revision joining 0884f655c0a6 and e2f3a1b9c640. No schema or data change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #44364 +/- ##
==========================================
+ Coverage 80.30% 80.32% +0.01%
==========================================
Files 2929 2930 +1
Lines 174172 174300 +128
Branches 40450 40461 +11
==========================================
+ Hits 139876 140007 +131
+ Misses 31639 31622 -17
- Partials 2657 2671 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Reviewed No blocking correctness findings from the Python and migration reviews. The full migration graph has exactly the two expected parent heads before this change and only One nonblocking typing nit at lines 26–27: under our strict assignment-annotation convention, prefer Verification limits: graph analysis and direct no-op callback execution, not an independently executed database upgrade/downgrade round trip. Please complete the migration checklist with actual downgrade verification and runtime/downtime evidence. At the final check, migration guards, SQLite integration, pre-commit and unit tests passed; MySQL/PostgreSQL integration were still running, with no failed checks observed. The committer lens therefore remained process-only under its CI-first rule, not a completed code approval. Required migration approvals and remaining CI still apply; this comment is not a substitute for maintainer approval. The merge-time guard improvement that would prevent recurrence can be handled separately from this focused repair. |
Regenerate the PR merge snapshot after apache#44364 merged the migration heads. No source or tree changes; old Actions reruns retain the broken merge SHA and are not repaired-graph evidence. Keep sc-120945 separate and post-GA.
|
Bito Automatic Review Skipped – PR Already Merged |
…o master's merge 0e8bab8c31a3 merged the same two heads (0884f655c0a6, e2f3a1b9c640) that 60f94cd6cd11 already merged on master via #44364, re-splitting into two heads. Drop the duplicate merge and repoint the theme_editors.theme_id index migration at 60f94cd6cd11 instead. Co-Authored-By: Evan Rusackas <evan@preset.io> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…o master's merge 0e8bab8c31a3 merged the same two heads (0884f655c0a6, e2f3a1b9c640) that 60f94cd6cd11 already merged on master via #44364, re-splitting into two heads. Drop the duplicate merge and repoint the theme_editors.theme_id index migration at 60f94cd6cd11 instead. Co-Authored-By: Evan Rusackas <evan@preset.io> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…o master's merge 0e8bab8c31a3 merged the same two heads (0884f655c0a6, e2f3a1b9c640) that 60f94cd6cd11 already merged on master via #44364, re-splitting into two heads. Drop the duplicate merge and repoint the theme_editors.theme_id index migration at 60f94cd6cd11 instead. Co-Authored-By: Evan Rusackas <evan@preset.io> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
SUMMARY
mastercurrently has two alembic heads, sosuperset db upgradeaborts before applying anything:The two heads are:
e2f3a1b9c640— merge purge-audit pruning and username index heads("c7f53d184ea2", "88a01c781622")0884f655c0a6— merge task_dependencies with theme_editors heads("7e2c9a4f1b83", "aa5fa339627c")Neither is an ancestor of the other. The themes branch was long-lived and carried its own merge revisions, which were computed against a
masterthat predatede2f3a1b9c640; merging it re-branched the graph.This PR adds a single empty merge revision (
60f94cd6cd11) withdown_revision = ("0884f655c0a6", "e2f3a1b9c640"). There is no schema or data change —upgrade()anddowngrade()are empty. It mirrors the shape of the prior merge revision ine2f3a1b9c640.This unblocks integration CI repo-wide: every open PR's integration legs are dying in 1–2 minutes on this signature, before any tests run, including PRs that add no migrations at all.
Note that the
enforce-single-migration-headcheck does not catch this class of break, because it only inspects the migrations a PR itself adds. It passes green on PRs that are being broken bymaster's divergent graph, so its status says nothing about whethermaster's graph has converged.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — migration graph change only.
TESTING INSTRUCTIONS
Against a fresh SQLite metadata database:
ADDITIONAL INFORMATION