Repository navigation
fix(ci): align superset-cache tag consumers with the Dockerfile PY_VER - #44534
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #44534 +/- ##
===========================================
+ Coverage 66.18% 80.86% +14.68%
===========================================
Files 2945 2946 +1
Lines 176858 176962 +104
Branches 40973 41022 +49
===========================================
+ Hits 117045 143103 +26058
+ Misses 57318 31158 -26160
- Partials 2495 2701 +206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This is blocking unrelated PRs — Reproduced on a clean The direction here looks right: Any blocker to taking this out of draft? |
|
Thanks @aminghadersohi for the PR. I missed this part after resolving merge conflicts! This is already LGTM |
|
Sorry @aminghadersohi, I put the PR forward for review but tbh, its merge-able as of now. Thanks once again! |
Pick up apache#44534 (docker-cache-ref alignment) so the required unit-tests check passes; no conflicts with the screenshot changes.
Rebase onto master picked up the cache-ref fix (apache#44534) but master also gained a new "Display format" string (native filters) since the last regen here. Topped up the pot/po regen to match. Co-Authored-By: Evan Rusackas <evan@preset.io> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Bito Automatic Review Skipped – PR Already Merged |
TL;DR: Align the two frontend workflow cache consumers with the Dockerfile's existing
3.11-slim-trixiedefault to fix the cache-reference guard test on master.SUMMARY
Master is currently red on
tests/unit_tests/scripts/docker_cache_ref_test.py::test_cache_ref_matches_dockerfile_py_ver: running the test file on unchanged master reproduces two failures and three passes.#44250 added the guard test and changed both frontend workflow cache references to
apache/superset-cache:3.11.14-slim-trixiewithout changingDockerfile'sARG PY_VER=3.11-slim-trixie. The test has no skip logic for this mismatch.Align the consumers back to
apache/superset-cache:3.11-slim-trixie, which also matches the cache exporter derived from the Dockerfile. All five files inCACHE_REF_CONSUMERSwere checked; the three Compose files already match and need no changes.The Dockerfile is intentionally unchanged. Pinning its Python base image to
3.11.14would change the base-image selection for Python images, a separate product decision outside this CI fix.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; CI configuration only.
TESTING INSTRUCTIONS
Run:
Local results: all five tests pass, and all applicable pre-commit hooks pass. Before the change, the same test command fails for the two workflow consumers.
ADDITIONAL INFORMATION