Skip to content

fix(ci): align superset-cache tag consumers with the Dockerfile PY_VER - #44534

Merged
hughhhh merged 2 commits into
apache:masterfrom
aminghadersohi:sc-121649-cache-ref-align
Sep 22, 2026
Merged

hughhhh merged 2 commits into
apache:masterfrom
aminghadersohi:sc-121649-cache-ref-align

Conversation

@aminghadersohi

Copy link
Copy Markdown
Contributor

TL;DR: Align the two frontend workflow cache consumers with the Dockerfile's existing 3.11-slim-trixie default to fix the cache-reference guard test on master.

SUMMARY

Master is currently red on tests/unit_tests/scripts/docker_cache_ref_test.py::test_cache_ref_matches_dockerfile_py_ver: running the test file on unchanged master reproduces two failures and three passes.

#44250 added the guard test and changed both frontend workflow cache references to apache/superset-cache:3.11.14-slim-trixie without changing Dockerfile's ARG PY_VER=3.11-slim-trixie. The test has no skip logic for this mismatch.

Align the consumers back to apache/superset-cache:3.11-slim-trixie, which also matches the cache exporter derived from the Dockerfile. All five files in CACHE_REF_CONSUMERS were checked; the three Compose files already match and need no changes.

The Dockerfile is intentionally unchanged. Pinning its Python base image to 3.11.14 would change the base-image selection for Python images, a separate product decision outside this CI fix.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Not applicable; CI configuration only.

TESTING INSTRUCTIONS

Run:

PYTHONPATH=superset-core/src pytest tests/unit_tests/scripts/docker_cache_ref_test.py -q
uvx pre-commit run --files .github/workflows/superset-frontend.yml .github/workflows/frontend-bundle-size-nightly.yml

Local results: all five tests pass, and all applicable pre-commit hooks pass. Before the change, the same test command fails for the two workflow consumers.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.86%. Comparing base (c6d0890) to head (69bfaeb).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #44534       +/-   ##
===========================================
+ Coverage   66.18%   80.86%   +14.68%     
===========================================
  Files        2945     2946        +1     
  Lines      176858   176962      +104     
  Branches    40973    41022       +49     
===========================================
+ Hits       117045   143103    +26058     
+ Misses      57318    31158    -26160     
- Partials     2495     2701      +206     
Flag Coverage Δ
hive 36.94% <ø> (ø)
javascript 76.26% <ø> (+0.04%) ⬆️
mysql 56.19% <ø> (+<0.01%) ⬆️
postgres 56.19% <ø> (-0.01%) ⬇️
presto 38.88% <ø> (ø)
python 85.16% <ø> (+28.63%) ⬆️
sqlite 55.91% <ø> (ø)
unit 77.32% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hughhhh

hughhhh commented Sep 22, 2026

Copy link
Copy Markdown
Member

This is blocking unrelated PRs — tests/unit_tests/scripts/docker_cache_ref_test.py::test_cache_ref_matches_dockerfile_py_ver fails on master for both consumers, so every branch cut from it inherits two red unit-tests failures (and therefore a red unit-tests-required gate). Hit it on #43757, where the diff touches none of these files.

Reproduced on a clean origin/master checkout — Dockerfile, both workflows and the test file are byte-identical to master:

Dockerfile ARG PY_VER = 3.11-slim-trixie

ok    docker-compose.yml                                   refs=['3.11-slim-trixie']
ok    docker-compose-non-dev.yml                           refs=['3.11-slim-trixie']
ok    docker-compose-light.yml                             refs=['3.11-slim-trixie']
FAIL  .github/workflows/superset-frontend.yml              refs=['3.11.14-slim-trixie']
FAIL  .github/workflows/frontend-bundle-size-nightly.yml   refs=['3.11.14-slim-trixie']

The direction here looks right: scripts/docker-build-extra-flags.sh:68 exports apache/superset-cache:${DEFAULT_PY_VER}, sourced from the Dockerfile at :44, so 3.11-slim-trixie is the tag anything actually writes — the two workflows were pulling one nothing publishes, which means they were getting cold builds too, not just a red test.

Any blocker to taking this out of draft?

@hainenber

Copy link
Copy Markdown
Contributor

Thanks @aminghadersohi for the PR. I missed this part after resolving merge conflicts! This is already LGTM

@hainenber

Copy link
Copy Markdown
Contributor

Sorry @aminghadersohi, I put the PR forward for review but tbh, its merge-able as of now. Thanks once again!

@sadpandajoe sadpandajoe added the review:checkpoint Last PR reviewed during the daily review standup label Sep 22, 2026
@hughhhh
hughhhh merged commit ee4b8dd into apache:master Sep 22, 2026
143 checks passed
rebenitez1802 added a commit to rebenitez1802/superset that referenced this pull request Sep 22, 2026
Pick up apache#44534 (docker-cache-ref alignment) so the required unit-tests check
passes; no conflicts with the screenshot changes.
rusackas added a commit to wuhyn/superset that referenced this pull request Sep 22, 2026
Rebase onto master picked up the cache-ref fix (apache#44534) but master
also gained a new "Display format" string (native filters) since the
last regen here. Topped up the pot/po regen to match.

Co-Authored-By: Evan Rusackas <evan@preset.io>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@bito-code-review

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it

villebro pushed a commit that referenced this pull request Sep 22, 2026
#44534)

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
(cherry picked from commit ee4b8dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants