Repository navigation
fix(translations): regenerate messages.pot after the connection-move reword - #44574
Merged
Merged
Conversation
…reword apache#44036 reworded the connection-move error in superset/commands/database/exceptions.py to cover OAuth2 endpoint URIs and the OAuth2 client secret, but did not re-run the extraction. The committed template kept the old wording, so check_pot_drift.py fails on every open PR: one string in source missing from the template, one in the template no longer in source. Regenerated with ./scripts/translations/babel_update.sh. The only content change is that msgid, propagated into the language catalogs; no catalog had the old string translated, so nothing is stranded. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Code Review Agent Run #bf1905Actionable Suggestions - 0Additional Suggestions - 6
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
github-actions
Bot
added
i18n
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #44574 +/- ##
===========================================
+ Coverage 66.14% 80.99% +14.85%
===========================================
Files 2950 2950
Lines 177666 177666
Branches 41177 41177
===========================================
+ Hits 117509 143909 +26400
+ Misses 57653 31045 -26608
- Partials 2504 2712 +208
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
msyavuz
approved these changes
Sep 23, 2026
9 tasks
1 of 6 tasks
deepujain
added a commit
to deepujain/superset
that referenced
this pull request
Sep 23, 2026
Upstream apache#44574 landed the messages.pot regeneration on master; the babel-extract and unit-tests (check_pot_drift_test.py) failures on this PR were base drift, not contributor code. Fresh CI will run against the new merge commit with the fixed base pot.
deepujain
added a commit
to deepujain/superset
that referenced
this pull request
Sep 23, 2026
Upstream apache#44574 landed the messages.pot regeneration on master; the babel-extract failure on this PR was base drift, not contributor code. Fresh CI will run against the new merge commit with the fixed base pot.
deepujain
added a commit
to deepujain/superset
that referenced
this pull request
Sep 23, 2026
Upstream apache#44574 landed the messages.pot regeneration on master; the babel-extract and unit-tests (check_pot_drift_test.py) failures on this PR were base drift, not contributor code. Fresh CI will run against the new merge commit with the fixed base pot.
deepujain
added a commit
to deepujain/superset
that referenced
this pull request
Sep 23, 2026
Upstream apache#44574 landed the messages.pot regeneration on master; the babel-extract failure on this PR was base drift, not contributor code. Fresh CI will run against the new merge commit with the fixed base pot.
2 of 9 tasks
Merged
1 of 6 tasks
This was referenced Sep 24, 2026
1 of 4 tasks
1 of 6 tasks
deepujain
added a commit
to deepujain/superset
that referenced
this pull request
Oct 1, 2026
Upstream apache#44574 landed the messages.pot regeneration on master; the babel-extract and unit-tests (check_pot_drift_test.py) failures on this PR were base drift, not contributor code. Fresh CI will run against the new merge commit with the fixed base pot.
deepujain
added a commit
to deepujain/superset
that referenced
this pull request
Oct 9, 2026
Upstream apache#44574 landed the messages.pot regeneration on master; the babel-extract and unit-tests (check_pot_drift_test.py) failures on this PR were base drift, not contributor code. Fresh CI will run against the new merge commit with the fixed base pot. Signed-off-by: Deepak Jain <deepujain@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
babel-extractis failing on master and therefore on every open PR:#44036 reworded the connection-move error in
superset/commands/database/exceptions.pyso that it also covers OAuth2 endpoint URIs and the OAuth2 client secret, but the extraction was not re-run. The committed template kept the old wording, soscripts/translations/check_pot_drift.pysees one string in source that is not in the template and one in the template that is no longer in source. That check runs before anything else in the job, so the wholebabel-extractjob stops there.Because CI builds the merge ref, this fails on PRs that do not touch Python or translations at all. It is currently red on the tip of master (7dd70ea).
The fix is the one the failure message asks for:
./scripts/translations/babel_update.sh, with the regenerated template and catalogs committed.The only content change is that one msgid, propagated from the template into the 30 language catalogs:
No translation is stranded by the reword. The string is new enough that no catalog had translated it, so every
msgstron both sides of the change is empty. The rest of the diff is thePOT-Creation-Datestamp that the script rewrites in each file.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable.
TESTING INSTRUCTIONS
On master this exits 1 and prints the two drifted strings. On this branch it exits 0 with
superset/translations/messages.pot matches a fresh extraction.To confirm the regeneration is reproducible rather than hand-edited, re-run the script and check that nothing changes:
./scripts/translations/babel_update.sh git diff --stat # only POT-Creation-Date, which is stamped with the current timeADDITIONAL INFORMATION
🤖 Generated with Claude Code