Repository navigation
feat(pivot-table): add result aggregation to tabular exports #44679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fitzee
wants to merge
5
commits into
apache:master
Choose a base branch
from
fitzee:codex/pivot-result-exports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6e8c902
feat(pivot-table): add result aggregation to tabular exports
fitzee 81d3945
chore(pivot-table): merge master into result exports
fitzee d370310
Merge branch 'master' into codex/pivot-result-exports
fitzee 71d3b97
fix(pivot-table): correct result export scopes and formatting
fitzee 70bf9ed
fix(pivot-table): align currency indexes and datetime summary keys
fitzee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
|
|
||
| # Pivot result aggregation exports | ||
|
|
||
| Pivot Table result aggregation summarizes the grouped metric values returned by | ||
| the chart query. For example, with grouped values 1, 9, 20 and 100, a saved | ||
| **Median** aggregation produces a grand summary of 14.5. It does not calculate the median | ||
| of intermediate subtotals. Query filters and row limits apply before this step. | ||
|
|
||
| ## Saved aggregation settings | ||
|
|
||
| The chart control panel exposes **Show values as**, but does not expose a | ||
| result-aggregation selector. This export behavior applies to charts whose saved | ||
| configuration already contains an `aggregateFunction`, for example from a | ||
| version with an aggregation selector. This page does not describe a new control | ||
| available in the chart editor. | ||
|
|
||
| A missing, unrecognized or **Metric** setting keeps metric-definition behavior. | ||
| Saved settings such as **Sum**, **Average** and **Median** apply a second | ||
| aggregation to the returned grouped results. | ||
|
|
||
| Row and column subtotals can be enabled independently of grand totals. A shared | ||
| total combining different metrics is blank because those metrics do not have a | ||
| single meaningful aggregate. This also applies when metrics are placed on rows | ||
| or the table is transposed. | ||
|
|
||
| ## Fractions and formatting | ||
|
|
||
| **Sum as Fraction of Total**, **Rows** or **Columns**, and the corresponding | ||
| **Count** choices, use only their own metric in the denominator. Result | ||
| aggregation takes precedence over the separate **Show values as** setting. | ||
| Without a saved result aggregation, that setting applies to database-computed | ||
| metric values. | ||
|
|
||
| Formatted results display fractions as percentages, including when a metric has | ||
| a currency override. CSV exports retain raw numeric ratios. Excel fractions | ||
| remain numeric cells with a percentage number format, so they can be used in | ||
| formulas. Other formatted results retain their configured formats; AUTO currency formatting uses the currencies of the | ||
| records contributing to each cell or subtotal. | ||
|
|
||
| ## Missing values | ||
|
|
||
| Numeric result reducers ignore NULL observations. **First** takes the first | ||
| non-NULL value, while **Last** retains the final value even when it is NULL. | ||
| Sample variance and sample standard deviation are zero for a single numeric | ||
| observation. Stored database totals are not additional observations: result | ||
| aggregation uses the leaf query results. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This says AUTO currency uses the contributing records of each cell or subtotal, but
Countand its fraction variants skip that context (PIVOT_AGGREGATIONS_WITHOUT_CURRENCY_CONTEXT) and use the query-wide detected currency. An analyst exporting a saved Count chart over USD and EUR groups would expect local symbols, whiletest_pivot_table_v2_count_auto_currency_uses_detected_fallbackasserts the fallback currency for both. Could the page note the Count exception?