fix(explore): prevent duplicate onChange calls in RadioButtonControl (#44921) by FrancescoCastaldi · Pull Request #44945 · apache/superset

FrancescoCastaldi · 2026-10-03T11:31:03Z

SUMMARY

RadioButtonControl previously wired onChange in two places:

On the <Radio.Group> container (onChange={e => onChange(e.target.value)})
In the onClick handler on each <Radio.Button> (onClick={e => { e.currentTarget?.focus(); onChange(val); }})

Because of this duplicate wiring:

Selecting an unselected radio option fired onChange twice with the same value, causing redundant dispatches and re-renders in Explore controls (control panel, ColumnConfig form items, MapView, ZoomConfig).
Clicking an already-selected radio option fired onChange through the button's onClick even though the selection did not change.

This PR keeps onChange handling exclusively on <Radio.Group> and retains focus management (e.currentTarget?.focus()) in the button onClick handler without invoking onChange.

TESTING INSTRUCTIONS

Run automated unit tests:

npm test -- packages/superset-ui-chart-controls/test/shared-controls/components/RadioButtonControl.test.tsx

Verify all 35 tests pass, confirming:
- onChange is called exactly once when clicking an unselected option
- onChange is not called when clicking an already-selected option
- Focus is still correctly set on click

ADDITIONAL INFORMATION

Has associated issue: Fixes RadioButtonControl calls onChange twice per selection (Radio.Group onChange plus a per-button onClick) #44921
Required feature flags:
Changes UI
Includes DB Migration
Introduces new feature or API
Removes existing feature or API

bito-code-review · 2026-10-03T11:31:14Z

Code Review Agent Run #1f6470

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 7611488..7611488
- superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/RadioButtonControl.tsx
- superset-frontend/packages/superset-ui-chart-controls/test/shared-controls/components/RadioButtonControl.test.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers an incremental AI Review.
/review full - Manually triggers a full AI Review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

…invocation (apache#44921) Signed-off-by: Francesco Castaldi <info@francescocastaldi.it>

…eady selected option (apache#44921) Signed-off-by: Francesco Castaldi <info@francescocastaldi.it>

…n selections (apache#44921) Signed-off-by: Francesco Castaldi <info@francescocastaldi.it>

… onClick handler (apache#44921) RadioButtonControl previously wired onChange both on the Radio.Group wrapper and in an onClick handler on each Radio.Button. Selecting an option triggered both handlers with the same value, causing duplicate updates, redundant renders, and duplicate Redux dispatches across Explore controls. Clicking an already-selected option also triggered onChange redundantly. Keep onChange handling exclusively on Radio.Group and retain focus management in the button onClick handler. Fixes: apache#44921 Signed-off-by: Francesco Castaldi <info@francescocastaldi.it>

…n tests (apache#44921) Signed-off-by: Francesco Castaldi <info@francescocastaldi.it>

codecov · 2026-10-03T11:46:54Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.28%. Comparing base (549508b) to head (6463eaf).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #44945   +/-   ##
=======================================
  Coverage   82.28%   82.28%           
=======================================
  Files        2996     2996           
  Lines      185109   185115    +6     
  Branches    42834    42839    +5     
=======================================
+ Hits       152316   152322    +6     
  Misses      30031    30031           
  Partials     2762     2762

Flag	Coverage Δ
javascript	`77.89% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bito-code-review · 2026-10-03T14:37:14Z

Code Review Agent Run #9fbd8c

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 3b0cd6d..6463eaf
- superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/RadioButtonControl.tsx
- superset-frontend/packages/superset-ui-chart-controls/test/shared-controls/components/RadioButtonControl.test.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers an incremental AI Review.
/review full - Manually triggers a full AI Review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

pull-request-size Bot added the size/M label Oct 3, 2026

github-actions Bot added the packages label Oct 3, 2026

FrancescoCastaldi added 5 commits October 3, 2026 13:33

test(chart-controls): add reproduction assertion for single onChange …

3b0cd6d

…invocation (apache#44921) Signed-off-by: Francesco Castaldi <info@francescocastaldi.it>

test(chart-controls): assert no onChange invocation when clicking alr…

005b7f3

…eady selected option (apache#44921) Signed-off-by: Francesco Castaldi <info@francescocastaldi.it>

test(chart-controls): assert exact call count across sequential optio…

16271ea

…n selections (apache#44921) Signed-off-by: Francesco Castaldi <info@francescocastaldi.it>

test(chart-controls): update null-value and normalizeOption transitio…

6463eaf

…n tests (apache#44921) Signed-off-by: Francesco Castaldi <info@francescocastaldi.it>

FrancescoCastaldi force-pushed the fix/radio-button-control-duplicate-onchange branch from 7611488 to 6463eaf Compare October 3, 2026 11:34

sadpandajoe self-requested a review October 5, 2026 17:11

sadpandajoe approved these changes Oct 5, 2026

View reviewed changes

Navigation Menu

Repository navigation

fix(explore): prevent duplicate onChange calls in RadioButtonControl (#44921) - #44945

fix(explore): prevent duplicate onChange calls in RadioButtonControl (#44921)#44945
FrancescoCastaldi wants to merge 5 commits into
apache:masterfrom
FrancescoCastaldi:fix/radio-button-control-duplicate-onchange

FrancescoCastaldi commented Oct 3, 2026

Uh oh!

bito-code-review Bot commented Oct 3, 2026 •

edited

Loading

Code Review Agent Run #1f6470

Uh oh!

codecov Bot commented Oct 3, 2026

Uh oh!

bito-code-review Bot commented Oct 3, 2026 •

edited

Loading

Code Review Agent Run #9fbd8c

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

FrancescoCastaldi commented Oct 3, 2026

SUMMARY

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #1f6470

Uh oh!

codecov Bot commented Oct 3, 2026

Codecov Report

Uh oh!

bito-code-review Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #9fbd8c

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bito-code-review Bot commented Oct 3, 2026 •

edited

Loading

bito-code-review Bot commented Oct 3, 2026 •

edited

Loading