Skip to content

feat(chart): backport x-axis label cross-filter with dimensions to 6.2 (#44869) - #45001

Merged
michael-s-molina merged 1 commit into
apache:6.2from
luizotavio32:backport/44869-xaxis-label-cross-filter-6.2
Oct 6, 2026
Merged

feat(chart): backport x-axis label cross-filter with dimensions to 6.2 (#44869)#45001
michael-s-molina merged 1 commit into
apache:6.2from
luizotavio32:backport/44869-xaxis-label-cross-filter-6.2

Conversation

@luizotavio32

@luizotavio32 luizotavio32 commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

SUMMARY

Backport of #44869 to 6.2.

On 6.2, clicking an x-axis label on bar, line, area and scatter charts only cross-filters when the chart has no dimensions. On a chart like "cases by agent, broken down by status", you can filter by status but not by agent.

With this backport, clicking an x-axis label (the y-axis labels on horizontal bars) cross-filters by that value even when dimensions are set. Clicking a bar or point keeps filtering by its dimension values, as before, and series are no longer dimmed while an x-axis filter is active.

6.2 only supports cross-filtering from categorical x-axes, so this backport covers categorical axes only. The temporal x-axis parts of the original PR are left out.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See #44869.

TESTING INSTRUCTIONS

Unit tests from the original PR are included, adapted to 6.2.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

🤖 Generated with Claude Code

@luizotavio32 @claude
feat(chart): cross-filter by x-axis label on charts with dimensions (a…
e8feb19 
…pache#44869)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit ef64bac)
@bito-code-review

bito-code-review Bot commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at evan@preset.io.

@luizotavio32

luizotavio32 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

/review

@luizotavio32
luizotavio32 marked this pull request as ready for review October 6, 2026 01:05
@bito-code-review

bito-code-review Bot commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Agent Run #914953

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: e8feb19..e8feb19
    • superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.test.tsx
    • superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx
    • superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
    • superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
    • superset-frontend/plugins/plugin-chart-echarts/src/constants.ts
    • superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
    • superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformers.test.ts
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers an incremental AI Review.

  • /review full - Manually triggers a full AI Review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@luizotavio32
luizotavio32 marked this pull request as draft October 6, 2026 01:05
@netlify

netlify Bot commented Oct 6, 2026

Copy link
Copy Markdown

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit e8feb19
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6ac448f359e1180008e74bac
😎 Deploy Preview https://deploy-preview-45001--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codeant-ai-for-open-source

codeant-ai-for-open-source Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

CodeAnt PR Risk: Low Risk

  • The PR appears safe to merge; categorical axis labels can now apply value-based cross-filters when dimensions are configured.
  • Tests cover axis-label filtering, duplicate-click and context-menu suppression, and preserving series styling for axis filters.

Assessed commit: e8feb1946eb5

@luizotavio32
luizotavio32 marked this pull request as ready for review October 6, 2026 01:28
@michael-s-molina
michael-s-molina merged commit 3f91970 into apache:6.2 Oct 6, 2026
138 of 164 checks passed
@luizotavio32
luizotavio32 deleted the backport/44869-xaxis-label-cross-filter-6.2 branch October 6, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees

No one assigned

Labels

plugins risk:chart-metadata size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luizotavio32 @michael-s-molina