[OOC] IO Handler Performance Improvements and Generalization#2532
Open
janniklinde wants to merge 1 commit into
Open
[OOC] IO Handler Performance Improvements and Generalization#2532janniklinde wants to merge 1 commit into
janniklinde wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2532 +/- ##
============================================
- Coverage 71.65% 71.60% -0.05%
- Complexity 49328 49395 +67
============================================
Files 1580 1585 +5
Lines 190516 190967 +451
Branches 37364 37424 +60
============================================
+ Hits 136507 136746 +239
- Misses 43486 43660 +174
- Partials 10523 10561 +38 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves performance and generality of
OOCMatrixIOHandler. We introduce experimental input/output streams that worked better in practice for OOC spilling in local experiments. We also introduce a lightweightOOCFutureto replaceCompletableFuturein hot paths.