Removing restangular by ocket8888 · Pull Request #3595 · apache/trafficcontrol

ocket8888 · 2019-05-22T13:57:48Z

What does this PR (Pull Request) do?

Removes a dependency that Traffic Portal had on Restangular.

This PR resolves TP: remove Restangular dependency #3571 and fixes TP: Generate ISO view won't resolve #4194

Which Traffic Control components are affected by this PR?

Traffic Portal

Traffic Portal dependencies are not individually documented, and so no changes are necessary.

What is the best way to verify this PR?

No functionality should have changed (except that errors will now be logged instead of ignored in many cases), so the existing tests should all pass.

Jeremy: actually, the only way to truly verify that the functionality did not change is to:

run the UI tests (which is a very small subset of all TP functionality)
manually verify the functionality associated with ALL the services functions that changed just to be sure all is well.

The following criteria are ALL met by this PR

This PR includes tests OR I have explained why tests are unnecessary
I have explained why documentation is unnecessary
This PR includes an update to CHANGELOG.md
This PR includes any and all required license headers
This PR does not include a database migration
This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

asfgit · 2019-05-22T20:16:44Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3717/
Test PASSed.

mitchell852

still reviewing but here's what i've found so far

asfgit · 2019-05-23T13:42:23Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3721/
Test PASSed.

mitchell852

lots of stuff broken. better retest.

asfgit · 2019-05-24T15:11:27Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3728/
Test PASSed.

asfgit · 2019-05-28T15:29:18Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3734/
Test PASSed.

asfgit · 2019-05-28T15:49:42Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3735/
Test PASSed.

mitchell852 · 2019-05-28T17:43:04Z

this whole timeout thing is weird. maybe it can be removed. i'll test it out. can't remember why i put it in here.

When I remove it it also doesn't show up messages

mitchell852 · 2019-05-28T18:16:54Z

the more I think about it, I think this PR is just way too big / risky. it requires a lot of positive and negative testing to ensure it does not change/break functionality. imo you should tackle one "service" at a time. i.e. remove the use of restangular from cdnservice.js. and move down the list of "services" with a seperate PR until nothing uses restangular and the dependency can be removed altogether. otherwise, the risk is much too high given that TP doesn't have comprehensive regression tests in place.

ocket8888 · 2019-05-28T19:51:22Z

Alright man, you asked for it

I'm gonna leave this open as a draft - I'll rebase once the others are all merged and this will be the one that actually removes restangular entirely.

asf-ci · 2019-11-07T18:55:23Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4730/

mitchell852 · 2019-12-16T15:14:31Z

@ocket8888 to rebase

asf-ci · 2019-12-16T18:13:08Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4935/

asf-ci · 2019-12-16T18:54:51Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4936/

mitchell852

make sure to remove from traffic_portal/grunt/browserify2.js as well

asf-ci · 2019-12-16T21:40:37Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4941/

asf-ci · 2019-12-16T21:45:39Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4942/

changes requested were made

asf-ci · 2019-12-17T17:59:30Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4946/

mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 improvement The functionality exists but it could be improved in some way. labels May 22, 2019

ocket8888 force-pushed the removing-restangular branch from 4631e74 to 855943f Compare May 22, 2019 20:05

mitchell852 reviewed May 22, 2019

View reviewed changes

Comment thread traffic_portal/app/src/common/api/ASNService.js Outdated

mitchell852 suggested changes May 22, 2019

View reviewed changes

mitchell852 added tech debt rework due to choosing easy/limited solution and removed improvement The functionality exists but it could be improved in some way. labels May 22, 2019

mitchell852 suggested changes May 23, 2019

View reviewed changes

ocket8888 force-pushed the removing-restangular branch from 36e9ad8 to 34bad7c Compare May 24, 2019 14:55

mitchell852 reviewed May 24, 2019

View reviewed changes

Comment thread traffic_portal/app/src/common/api/CDNService.js Outdated

mitchell852 reviewed May 27, 2019

View reviewed changes

Comment thread traffic_portal/app/src/common/api/UserService.js Outdated

mitchell852 reviewed May 27, 2019

View reviewed changes

Comment thread traffic_portal/app/src/common/api/UserService.js Outdated

mitchell852 reviewed May 28, 2019

View reviewed changes

ocket8888 changed the title ~~Removing restangular~~ WIP - Removing restangular May 28, 2019

mitchell852 added the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label May 31, 2019

ocket8888 force-pushed the removing-restangular branch from 72420af to e1ea540 Compare November 7, 2019 18:51

mitchell852 mentioned this pull request Dec 16, 2019

TP: removes remaining restangular references #4193

Closed

7 tasks done

ocket8888 added 4 commits December 16, 2019 10:33

Removed Restangular from the codebase

ce7f3ff

updated changelog

e3ab264

fixed missing 'return' statements, typo, incorrect indexing

f7601c7

API Service methods now resolve explicitly

cfb3c50

Rejected promises throw instead of returning

f9b1599

ocket8888 force-pushed the removing-restangular branch from e1ea540 to f9b1599 Compare December 16, 2019 17:42

ocket8888 removed the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label Dec 16, 2019

Removed unrelated changes

87ea425

ocket8888 requested a review from mitchell852 December 16, 2019 17:53

ocket8888 changed the title ~~WIP - Removing restangular~~ Removing restangular Dec 16, 2019

mitchell852 previously requested changes Dec 16, 2019

View reviewed changes

removed from browserify

8109386

ocket8888 force-pushed the removing-restangular branch from 985fce7 to 8109386 Compare December 16, 2019 21:36

mitchell852 reviewed Dec 16, 2019

View reviewed changes

Comment thread traffic_portal/app/src/common/api/ProfileParameterService.js Outdated

rawlinp added this to the 4.0.0 milestone Dec 17, 2019

Remove unnecessary success message

356cd0d

mitchell852 merged commit aff0186 into apache:master Dec 17, 2019

ocket8888 deleted the removing-restangular branch December 17, 2019 17:00

Conversation

ocket8888 commented May 22, 2019 • edited by mitchell852 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

The following criteria are ALL met by this PR

Uh oh!

asfgit commented May 22, 2019

Uh oh!

Uh oh!

mitchell852 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asfgit commented May 23, 2019

Uh oh!

mitchell852 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asfgit commented May 24, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asfgit commented May 28, 2019

Uh oh!

asfgit commented May 28, 2019

Uh oh!

mitchell852 May 28, 2019

Choose a reason for hiding this comment

Uh oh!

ocket8888 May 28, 2019

Choose a reason for hiding this comment

Uh oh!

mitchell852 commented May 28, 2019

Uh oh!

ocket8888 commented May 28, 2019

Uh oh!

asf-ci commented Nov 7, 2019

Uh oh!

mitchell852 commented Dec 16, 2019

Uh oh!

asf-ci commented Dec 16, 2019

Uh oh!

asf-ci commented Dec 16, 2019

Uh oh!

mitchell852 left a comment

Choose a reason for hiding this comment

Uh oh!

asf-ci commented Dec 16, 2019

Uh oh!

asf-ci commented Dec 16, 2019

Uh oh!

Uh oh!

asf-ci commented Dec 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ocket8888 commented May 22, 2019 •

edited by mitchell852

Loading