Skip to content

Update gradle version and other changes in android apps - #10867

Closed
argrento wants to merge 7 commits into
apache:mainfrom
argrento:gradle-update
Closed

Update gradle version and other changes in android apps#10867
argrento wants to merge 7 commits into
apache:mainfrom
argrento:gradle-update

Conversation

@argrento

@argrento argrento commented Apr 1, 2022

Copy link
Copy Markdown
Contributor

@argrento argrento changed the title WIP: Update gradle version in android apps Update gradle version in android apps Apr 5, 2022
@TejashShah

Copy link
Copy Markdown

cc @masahi @areusch for review

@junrushao

Copy link
Copy Markdown
Member

Thanks for doing that! Also CC @Lyken17

@areusch

areusch commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

I'm not super-knowledgeable about Android stuff, but hopefully someone who is could review this PR?

@junrushao

Copy link
Copy Markdown
Member

@Lyken17 would love to ask you to try out and review this PR!

@masahi masahi reopened this Apr 20, 2022
@argrento argrento changed the title Update gradle version in android apps Update gradle version and other changes in android apps Apr 21, 2022
@TejashShah

Copy link
Copy Markdown

Thanks @argrento for getting the CI passed.

@Lyken17 Please give it a try and review this PR.

@Lyken17

Lyken17 commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

Sry for being late, was busy for some conference experiments.

I rarely code in Java so I am afraid that I cannot comment much on the modified code. But I have seen @argrento update javah command to javac -h. This was the cause of building error when using latest JDK https://discuss.tvm.apache.org/t/jvmpkg-fails-to-build-on-mac-osx/11578/2

In my build machine (Intel Mac Mini), JDK version 1.8.0_312, Clang 13.0.0, all three projects android_camera, android_rpc, android_camera, android_deploy can build successfully without error.

(base) ligeng@Lgs-Mac-mini➜  tvm2 git:(gradle-update) ✗ gh pr checkout 10867
(base) ligeng@Lgs-Mac-mini➜  tvm2 git:(gradle-update) ✗ java -version
openjdk version "1.8.0_312"
OpenJDK Runtime Environment (build 1.8.0_312-bre_2021_10_21_00_49-b00)
OpenJDK 64-Bit Server VM (build 25.312-b00, mixed mode)

(base) ligeng@Lgs-Mac-mini➜  tvm2 git:(gradle-update) ✗ clang --version
Homebrew clang version 13.0.0
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /usr/local/opt/llvm/bin

(base) ligeng@Lgs-Mac-mini➜  tvm2 git:(gradle-update) ✗ llvm-config --version
13.0.0

Due to my limited (human) bandwidth, I may be able to test 2~3 more JDK / NDK versions. Would it be possible to setup CI auto-build test for the three demos? @argrento

@argrento

argrento commented May 8, 2022

Copy link
Copy Markdown
Contributor Author

New PR because I messed up a little bit :(

@argrento argrento closed this May 9, 2022
@TejashShah

Copy link
Copy Markdown

@Lyken17 We raised another PR #11241 and please review and give your blessing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants