[AutoTVM][Autoscheduler] Default build funcs inherit PassContext - #11618
Closed
AndrewZhaoLuo wants to merge 1 commit into
Closed
[AutoTVM][Autoscheduler] Default build funcs inherit PassContext#11618AndrewZhaoLuo wants to merge 1 commit into
AndrewZhaoLuo wants to merge 1 commit into
Conversation
Contributor
|
should we do something like assert if the PassContext changes between Tuner construction and calling |
Contributor
Author
|
Hmm, I don't think that would be super helpful since the issue comes from the fact that during tuning, the PassContext is ignored by the children processes which actually build stuff during tuning. So even if it does change, it doesn't really matter imo I guess we can make it so PassContext is inherited instead, which I guess I'll take a look, it will make things even more transparent. |
Contributor
Author
|
Just noticed I accidently opened this on main repo instead of my own fork, moved to #11632 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These funcs used building during the tuning process now inherit PassContext so we can inject things like pass instrumentation into the build process during tuning.
Note, due to the fact subprocesses are used for building by default, we can't naively do something like
since new processes will not inherit the parents context.
But what does allow us to do is wrap the existing build functions with new PassContexts and call those instead making it a little more extensible.