Add -Bsymbolic-functions to linker option - #1244
Merged
Merged
Conversation
tqchen
approved these changes
Jun 7, 2018
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Jul 6, 2018
mnuyens
pushed a commit
to mnuyens/tvm
that referenced
this pull request
Jul 10, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of
extension_class_info<tvm::Target>::codeis 0 in libtvm.so and 28 in libtvm_topi.so. This can result in different implementations with the same function symbol between libtvm.so and libtvm_topi.so.Actualy, we cannot pass python_cpp tests when we use
-O0compiler option.To solve this problem, this PR adds -Bsymbolic-functions linker option to use the local function definition within the shared library.