Skip to content

[CODEGEN][CONTRIB] Various update for CoreML codegen - #5934

Merged
zhiics merged 2 commits into
apache:masterfrom
kazum:coreml_codegen_update
Jun 26, 2020
Merged

[CODEGEN][CONTRIB] Various update for CoreML codegen#5934
zhiics merged 2 commits into
apache:masterfrom
kazum:coreml_codegen_update

Conversation

@kazum

@kazum kazum commented Jun 26, 2020

Copy link
Copy Markdown
Contributor

@zhiics

zhiics commented Jun 26, 2020

Copy link
Copy Markdown
Member

aah, I haven't noticed that CoreML codegen was also using BYOC infra. Thanks for updating it. I have a question which is not relevant to this change. I see SetInput needs to allocate memory and copy from DLTensor to the local memory every time. Is it possible to pre-allocate memory or directly do zero-copy by sharing the passed tensor?

@kazum

kazum commented Jun 26, 2020

Copy link
Copy Markdown
Contributor Author

@zhiics Relevant changes to #5770 are:
https://github.com/apache/incubator-tvm/pull/5934/files#diff-639424334c798703f0e62ec8a5eaf779R30
https://github.com/apache/incubator-tvm/pull/5934/files#diff-271e7167e72d0f1de3aee097fa5cb5d2R232-R245

Is it possible to pre-allocate memory or directly do zero-copy by sharing the passed tensor?

We can at least pre-allocate memory. I think of doing more optimization for input tensor management in another PR :)

@zhiics

zhiics commented Jun 26, 2020

Copy link
Copy Markdown
Member

@kazum no problem. We shouldn't do that in this PR. I was just curious if you have a plan to do that.

@zhiics
zhiics merged commit 69313a7 into apache:master Jun 26, 2020
@zhiics

zhiics commented Jun 26, 2020

Copy link
Copy Markdown
Member

Thanks @kazum

@kazum
kazum deleted the coreml_codegen_update branch June 26, 2020 19:06
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 30, 2020
* [CODEGEN][CONTRIB] Various update for CoreML codegen

* fix lint error
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
* [CODEGEN][CONTRIB] Various update for CoreML codegen

* fix lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants