[CI] Install DNNL (OneDNN) to CI Environment - #5936
Merged
Merged
Conversation
Member
|
Please confirm if the dnnl works with AMD cpu, as we also have AMD cpus in the CI. |
Contributor
Author
|
OK will verify it on EC2 M5a instance and get back here. |
Contributor
Author
|
Verified that this docker image with DNNL works for AMD CPU (EC2 m5a.4xlarge instance). |
tqchen
approved these changes
Jun 26, 2020
Member
|
OK, this is merged. the binary need to be manually updated, will report back when it is ready, |
Contributor
Author
|
HI @tqchen have you got a chance to update docker hub? Thanks. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
Member
|
Update, I tried to update. There was some problems wrt to the ci-cpu(not related to this PR) that needs to be fixed http://ci.tvm.ai:8080/job/temp-ci-docker-staging/job/ci-stage/39/execution/node/324/log/ before we can update the image |
Contributor
Author
|
Got it. Thanks for the update! |
This was referenced Jul 1, 2020
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current BYOC flow uses DNNL as an example backend to demonstrate and test its functionality, but all related tests are currently skipped in CI due to the lack of DNNL in the environment. In this PR, we add scripts to deploy pre-built DNNL to the docker image so that the unit tests in #5919 for example can be effective.
I've built a docker image locally and passed unit tests of #5919 with it.
cc @zhiics @tqchen