[RELAY][DYN] Dynamic broadcast_to, zeros, ones - #6007
Merged
Conversation
electriclilies
force-pushed
the
dynamic_broadcast_to
branch
from
July 7, 2020 19:03
4d66afa to
816784e
Compare
mbrookhart
requested changes
Jul 7, 2020
mbrookhart
left a comment
mbrookhart
left a comment
Contributor
There was a problem hiding this comment.
Thanks, Lily! A few things to clean up.
electriclilies
force-pushed
the
dynamic_broadcast_to
branch
from
July 9, 2020 18:59
dba1986 to
26f8871
Compare
electriclilies
changed the title
Contributor
|
@zhiics could you take a look? |
zhiics
reviewed
Jul 12, 2020
zhiics
left a comment
zhiics
left a comment
Member
There was a problem hiding this comment.
LGTM, only a few nitpicks. Please rebase.
electriclilies
force-pushed
the
dynamic_broadcast_to
branch
from
July 13, 2020 16:33
eec67be to
408a40b
Compare
electriclilies
force-pushed
the
dynamic_broadcast_to
branch
from
July 13, 2020 17:02
408a40b to
5c5025d
Compare
Contributor
Author
|
@zhiics Rebased and nitpicks fixed! |
zhiics
approved these changes
Jul 13, 2020
zhiics
left a comment
zhiics
left a comment
Member
There was a problem hiding this comment.
@kevinthesun @icemelon9 Any of you can help take a look as well?
Member
|
@electriclilies Could you modify the code according to the changes in #6047 |
…es to static BroadCastToRel
…amic to static test
electriclilies
force-pushed
the
dynamic_broadcast_to
branch
from
July 14, 2020 18:51
f05a489 to
53bab6c
Compare
added 2 commits
July 14, 2020 11:55
Member
|
Thanks @electriclilies @mbrookhart |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* Dynamic BroadcastTo * fixed lint! * add test_one_hot() back * add one_hot registration back * Dynamic BroadcastTo * fixed lint! * add one_hot registration back * fixed lint.. again * fixed lint * lint * responding to comments * skipping cuda in dynamic test * skipping cuda in dynamic test * fixed i386 test and GPU test * lint * starting ones and zeros * fixed dynamic ones and zeros, wrote dyn ones and zeros test * added static version of zeros, ones and added a check for size of types to static BroadCastToRel * added dynamic to static pass for zeros and ones, dynamic test and dynamic to static test * removed op_str in dyn to static pass test * fixed lint * fix lint hopefully * removed import const * removed import that was actually used * copy all attributes from broadcast_to, ones, zeros, full * responding to comments * fixed build error * finishing rebase * fix lint Co-authored-by: Lily Orth-Smith <lorthsmith@Lilys-MacBook-Pro.local>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* Dynamic BroadcastTo * fixed lint! * add test_one_hot() back * add one_hot registration back * Dynamic BroadcastTo * fixed lint! * add one_hot registration back * fixed lint.. again * fixed lint * lint * responding to comments * skipping cuda in dynamic test * skipping cuda in dynamic test * fixed i386 test and GPU test * lint * starting ones and zeros * fixed dynamic ones and zeros, wrote dyn ones and zeros test * added static version of zeros, ones and added a check for size of types to static BroadCastToRel * added dynamic to static pass for zeros and ones, dynamic test and dynamic to static test * removed op_str in dyn to static pass test * fixed lint * fix lint hopefully * removed import const * removed import that was actually used * copy all attributes from broadcast_to, ones, zeros, full * responding to comments * fixed build error * finishing rebase * fix lint Co-authored-by: Lily Orth-Smith <lorthsmith@Lilys-MacBook-Pro.local>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
* Dynamic BroadcastTo * fixed lint! * add test_one_hot() back * add one_hot registration back * Dynamic BroadcastTo * fixed lint! * add one_hot registration back * fixed lint.. again * fixed lint * lint * responding to comments * skipping cuda in dynamic test * skipping cuda in dynamic test * fixed i386 test and GPU test * lint * starting ones and zeros * fixed dynamic ones and zeros, wrote dyn ones and zeros test * added static version of zeros, ones and added a check for size of types to static BroadCastToRel * added dynamic to static pass for zeros and ones, dynamic test and dynamic to static test * removed op_str in dyn to static pass test * fixed lint * fix lint hopefully * removed import const * removed import that was actually used * copy all attributes from broadcast_to, ones, zeros, full * responding to comments * fixed build error * finishing rebase * fix lint Co-authored-by: Lily Orth-Smith <lorthsmith@Lilys-MacBook-Pro.local>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
* Dynamic BroadcastTo * fixed lint! * add test_one_hot() back * add one_hot registration back * Dynamic BroadcastTo * fixed lint! * add one_hot registration back * fixed lint.. again * fixed lint * lint * responding to comments * skipping cuda in dynamic test * skipping cuda in dynamic test * fixed i386 test and GPU test * lint * starting ones and zeros * fixed dynamic ones and zeros, wrote dyn ones and zeros test * added static version of zeros, ones and added a check for size of types to static BroadCastToRel * added dynamic to static pass for zeros and ones, dynamic test and dynamic to static test * removed op_str in dyn to static pass test * fixed lint * fix lint hopefully * removed import const * removed import that was actually used * copy all attributes from broadcast_to, ones, zeros, full * responding to comments * fixed build error * finishing rebase * fix lint Co-authored-by: Lily Orth-Smith <lorthsmith@Lilys-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a dynamic version of the relay broadcast_to, zeros and ones OP, and refactors the broadcast_to, zeros, ones OP to be purely static (not dynamic and static combined: undoes some of the refactor in https://github.com/apache/incubator-tvm/pull/5459/files). Also adds broadcast_to, zeros, ones to the dynamic to static conversion pass.