[ROCm] include mcpu and mtriple as target options - #6440
Closed
t-vi wants to merge 1 commit into
Closed
Conversation
Member
|
Nice, just today I did a clean install of rocm 3.7, and wondered why the benchmark is broken. So timely for me :) |
masahi
approved these changes
Sep 10, 2020
Member
|
@t-vi please rebase against the master to resolve conflicts |
Member
|
Hmmm I think the issue has been fixed by #6369 |
Contributor
Author
|
@junrushao1994 Right, thank you! @masahi @tqchen sorry for the noise. I had searched for rocm/mcpu patches but missed the more general one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the ROCm backend after #6347 to also allow mcpu and mtriple attributes for ROCm target objects.
With this change, we can run the gpu_imagenet_bench.py again.
@junrushao1994 @masahi