[Torch] Support bincount and scatter_add ops - #6740
Merged
Merged
Conversation
t-vi
suggested changes
Oct 23, 2020
t-vi
approved these changes
Oct 23, 2020
masahi
force-pushed
the
bincount-scatter_add
branch
from
October 23, 2020 21:53
decb436 to
c3e042f
Compare
tqchen
approved these changes
Oct 24, 2020
Member
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Oct 29, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
Contributor
|
Does the following code in |
Member
Author
|
Yes, bincount requires VM compile. |
Contributor
|
I'm working on adding TF bincount support. I found that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add numpy style
bincountop converter by combinations of existing ops.https://pytorch.org/docs/stable/generated/torch.bincount.html
This is a part of supporting hummingbird project. Also add a
scatter_addop conversion, as requested.I hope performance would not be too bad, so that we don't have to implement a native
bincountop.please review @siju-samuel @t-vi
cc @interesaaat