[BYOC] FTVMAnnotateTarget method signature update - #6786
Merged
Conversation
d-smirnov
force-pushed
the
register_op_attr
branch
from
October 28, 2020 19:31
45b4766 to
475835a
Compare
mbaret
requested changes
Oct 29, 2020
mbaret
left a comment
mbaret
left a comment
Contributor
There was a problem hiding this comment.
This change may allow us to simplify some logic for Ethos-N as well. I'll leave that for a follow-up patch though.
mbaret
requested changes
Oct 30, 2020
mbaret
left a comment
mbaret
left a comment
Contributor
There was a problem hiding this comment.
Some stuff has become registered when it shouldn't be.
Contributor
|
tensorrt.py changes look good |
d-smirnov
force-pushed
the
register_op_attr
branch
from
October 30, 2020 23:07
e424083 to
fe3c184
Compare
comaniac
requested changes
Nov 3, 2020
comaniac
left a comment
comaniac
left a comment
Contributor
There was a problem hiding this comment.
I'll block it first due to the unresolved comments. @d-smirnov please address the concern raised by @mbaret.
d-smirnov
force-pushed
the
register_op_attr
branch
from
November 3, 2020 19:34
fe3c184 to
87333e0
Compare
comaniac
approved these changes
Nov 3, 2020
Signature of FTVMAnnotateTarget changed to runtime::TypedPackedFunc<bool(const Expr& expr)> which allows to utilise extra information from passed expr argument.
d-smirnov
force-pushed
the
register_op_attr
branch
from
November 3, 2020 20:45
87333e0 to
6e4375b
Compare
Contributor
|
@mbaret PTAL and approve and request changes explicitly. Thanks. |
comaniac
approved these changes
Nov 3, 2020
Contributor
|
Thanks @d-smirnov @mbaret @lhutton1 @trevor-m |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
Signature of FTVMAnnotateTarget changed to runtime::TypedPackedFunc<bool(const Expr& expr)> which allows to utilise extra information from passed expr argument.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
Signature of FTVMAnnotateTarget changed to runtime::TypedPackedFunc<bool(const Expr& expr)> which allows to utilise extra information from passed expr argument.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
Signature of FTVMAnnotateTarget changed to runtime::TypedPackedFunc<bool(const Expr& expr)> which allows to utilise extra information from passed expr argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes signature of
FTVMAnnotateTargettoruntime::TypedPackedFunc<bool(const Expr& expr)>which allows to utilise extra information (e.g. an operation output type) from passed expr argument.