Mark zephyr install world-writable in docker image to unblock #7995. - #8037
Merged
Conversation
Contributor
Author
Member
|
@areusch I'm working on reproducing the issue. |
mehrdadh
requested changes
May 13, 2021
| # As part of the build process, Zephyr needs to touch some symlinks in zephyr/misc/generated/syscalls_links (this path is relative to the | ||
| # build directory for a project). Mark the zephyr installation world-writable since this is a docker | ||
| # container | ||
| chmod -R o+w /opt/zephyrproject |
Member
There was a problem hiding this comment.
maybe change it to ZEPHYR_PROJECT_PATH?
| ci_i386 = "tlcpack/ci-i386:v0.72-t0" | ||
| ci_qemu = "tlcpack/ci-qemu:v0.04" | ||
| ci_arm = "tlcpack/ci-arm:v0.03" | ||
| ci_lint = "tkonolige/ci-lint:latest" |
Contributor
Author
There was a problem hiding this comment.
oops, based on the wrong thing, reverted
Contributor
Author
There was a problem hiding this comment.
oops, based on the wrong thing, reverted
areusch
force-pushed
the
ci_1804-fix-qemu-build
branch
from
May 13, 2021 21:27
57b338a to
6755c3c
Compare
mehrdadh
approved these changes
May 13, 2021
tqchen
approved these changes
May 14, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unclear what happened here, but upon rebuilding ci-qemu, lots of:
marking Zephyr world-writable, which should resolve the need for make to touch the syscalls dependencies. This isn't strictly ideal, since a test could make modifications to Zephyr and corrupt following tests, but we have this issue everywhere and I believe Zephyr assumes it is writable when building.
Also remove some commented lines in the install script.