[ONNX] [Relay] Resize Opset 13 - #9265
Merged
Merged
Conversation
CircleSpin
requested review from
Huyuwei,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
merrymercy,
siju-samuel,
srkreddy1238,
tqchen and
yzhliu
as code owners
October 12, 2021 19:58
AndrewZhaoLuo
approved these changes
Oct 12, 2021
| ] | ||
| input_names = ["X", "roi", "scales"] | ||
|
|
||
| # if scales == []: |
Contributor
There was a problem hiding this comment.
Just remove this if you don't need it.
mbrookhart
approved these changes
Oct 12, 2021
mbrookhart
left a comment
mbrookhart
left a comment
Contributor
There was a problem hiding this comment.
Remove the commented code, otherwise LGTM, thanks!
ghost
reviewed
Oct 13, 2021
| @classmethod | ||
| def v11_13_common(cls, inputs, size, attr, params): | ||
| """ | ||
| Resize v11 and Resize v13 are identical except in how |
Contributor
Author
There was a problem hiding this comment.
Hi emijiayw, Thanks for your feedback! Resize v13 is specified for clarity since just resize could be misleading. :)
| def v11_13_common(cls, inputs, size, attr, params): | ||
| """ | ||
| Resize v11 and Resize v13 are identical except in how | ||
| they handle passing in scale and size. This utility |
| scale = inputs[2] | ||
| size = inputs[3] | ||
| if size is not None: | ||
| assert scale is None, "One of scale or size should be passed, not both." |
Contributor
Author
There was a problem hiding this comment.
both scale and size are singular (there is only one of them) and adding an 's' makes them plural. It's only one dog or cat, not dogs or cats 🐶 🐈 vs 🐶 🐶 🐶 🐈 🐈 🐈
| ), "One of scale or size should be passed, not both." | ||
| size = inputs[3] | ||
| else: | ||
| assert len(scale_shape) != 0, "One of scale or size should be passed." |
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
* Fix handling of optional inputs. * Missed one test in the ignore list. * split 11 and 13 * removed comments, adjusted for git review Co-authored-by: Josh Fromm <jwfromm@uw.edu> Co-authored-by: Matthew <mbrookhart@octoml.ai> Co-authored-by: CircleSpin <jocelyn@pop-os.localdomain>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* Fix handling of optional inputs. * Missed one test in the ignore list. * split 11 and 13 * removed comments, adjusted for git review Co-authored-by: Josh Fromm <jwfromm@uw.edu> Co-authored-by: Matthew <mbrookhart@octoml.ai> Co-authored-by: CircleSpin <jocelyn@pop-os.localdomain>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Fix handling of optional inputs. * Missed one test in the ignore list. * split 11 and 13 * removed comments, adjusted for git review Co-authored-by: Josh Fromm <jwfromm@uw.edu> Co-authored-by: Matthew <mbrookhart@octoml.ai> Co-authored-by: CircleSpin <jocelyn@pop-os.localdomain>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mbrookhart @AndrewZhaoLuo @anwang2009