[ONNX] Fix onnx convtranspose error - #9938
Merged
masahi merged 3 commits intoJan 15, 2022
Merged
Conversation
AndrewZhaoLuo
requested review from
Huyuwei,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
merrymercy,
siju-samuel,
srkreddy1238,
tqchen and
yzhliu
as code owners
January 14, 2022 23:02
masahi
approved these changes
Jan 15, 2022
crazydemo
pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
* fix mix up of channels with conv2d-transpose * add grouped convtranspose tests * turn off groups for non-llvm test
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* fix mix up of channels with conv2d-transpose * add grouped convtranspose tests * turn off groups for non-llvm test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ONNX translation erroneously thinks "groups" attribute refers to input channels when it refers to output channels.
This was probably the case before I switched Convtranspose layouts to fit regular convs more in PR #9336
Should close issue #9885