[microNPU] Removing constant args from PrimFunc - #9951
Merged
Mousius merged 2 commits intoJan 28, 2022
Conversation
manupak
requested review from
Hzfengsy,
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kparzysz-quic,
masahi,
mbaret,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
January 17, 2022 18:08
manupak
marked this pull request as draft
January 17, 2022 18:09
Contributor
Author
|
|
manupak
force-pushed
the
micronpu_remove_constant_primfunc_args
branch
3 times, most recently
from
January 21, 2022 11:03
aaaed60 to
e48b784
Compare
manupak
force-pushed
the
micronpu_remove_constant_primfunc_args
branch
2 times, most recently
from
January 26, 2022 16:00
220f665 to
9defb94
Compare
manupak
marked this pull request as ready for review
January 26, 2022 16:02
Contributor
Author
|
@mbaret a review here is appreciated! |
manupak
force-pushed
the
micronpu_remove_constant_primfunc_args
branch
from
January 27, 2022 23:33
c6711f8 to
21bc512
Compare
Before this commit, microNPU creates PrimFunc as if it accepts constants from the callee. This commit changes the PrimFunc to remove the constants as an argument to PrimFunc as they are not provided from the main function. Change-Id: If1fe2b8bcd9daf73ecabbb7930451de81e6f7e3b
Adjusting unit tests work with no constants args in the primfunc. Change-Id: Ic337a9f16bacd8980a10d9b412a3e8c9e7e3beb3
manupak
force-pushed
the
micronpu_remove_constant_primfunc_args
branch
from
January 28, 2022 10:40
21bc512 to
74f8cd8
Compare
Member
|
Thanks @manupa-arm / @mbaret - I declare this PR merged! 😸 |
sunggg
pushed a commit
to sunggg/tvm
that referenced
this pull request
Jan 29, 2022
Before this commit, microNPU creates PrimFunc as if it accepts constants from the callee. This commit changes the PrimFunc to remove the constants as an argument to PrimFunc as they are not provided from the main function.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
Before this commit, microNPU creates PrimFunc as if it accepts constants from the callee. This commit changes the PrimFunc to remove the constants as an argument to PrimFunc as they are not provided from the main function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, microNPU creates PrimFunc as if it accepts constants from the callee. This commit changes the PrimFunc to remove the constants as an argument to PrimFunc as they are not provided from the main function.