Repository navigation
Move default.py into its own file - #312
Merged
Merged
Conversation
shardulc
reviewed
Jan 3, 2018
| """), file=f) | ||
| f.close() | ||
| def create_default_config(fn): | ||
| os.system('cp {:} {:}'.format( |
Member
There was a problem hiding this comment.
cp might not always be available on the system.
Collaborator
Author
There was a problem hiding this comment.
Good point. Let's go for a more verbose version.
Member
|
Looks good to me. My only concern is that there are two |
Collaborator
Author
|
I would rather call it |
Member
|
|
Member
|
Looks good to me. However I feel like we should wait for @jonorthwash on this. |
Member
|
Agreed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311