This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Repository navigation
Permit null as an enum value in referenced schemas - #59
Merged
Merged
Conversation
The logic to check if we need to dereference a schema was failing in a case where we would find `null` as a value on an enum. As we're checking for the presence of `null.$ref` which causes an error to be thrown: > Cannot read property '$ref' of null
honzajavorek
approved these changes
Jan 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic to check if we need to dereference a schema was failing in a case where we would find
nullas a value on an enum. As we're checking for the presence ofnull.$refwhich causes an error to be thrown:This is a little tricky to test as it is a combination of things happen and thus I have not created a unit regression test but only a regression integration fixture. This problem can only happen when you reference another schema, for example the following tests pass without these fixes:
It's only when
convertSchemais used when the schema references another schema where you'd be able to reproduce.