Add support for IAsyncEnumerable #175 - #176
Conversation
|
Can you add any tests or something in the sample demonstrating its usage? |
|
I just added tests and a sample endpoint. |
| <ItemGroup> | ||
| <ProjectReference Include="..\SampleEndpointApp\SampleEndpointApp.csproj" /> | ||
| <ProjectReference Include="..\..\src\Ardalis.ApiEndpoints\Ardalis.ApiEndpoints.csproj"> | ||
| <SetTargetFramework>TargetFramework=netstandard2.1</SetTargetFramework> |
There was a problem hiding this comment.
Will this be an issue for NuGet consumers?
There was a problem hiding this comment.
Maybe it makes sense to migrate whole package to netstandard2.1. It's only intended to be used in ASP.NET Core anyway
There was a problem hiding this comment.
Will this be an issue for NuGet consumers?
I remember reading something about it, but did not have time to try.
Maybe it makes sense to migrate whole package to
netstandard2.1. It's only intended to be used in ASP.NET Core anyway
I would personally like to upgrade to netstandard2.1.
The compatibility table is here:
https://docs.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-1#select-net-standard-version
There was a problem hiding this comment.
@ardalis any thoughts about upgrading to netstandard2.1?
There was a problem hiding this comment.
#180 has bumped the target framework to netcore3.1, so I removed the netstandard2.1 stuff.
code is so much cleaner now :)
Solves #175
IAsyncEnumerableis only available since netstandard2.1.So I made the
EndpointBaseclasses partial, added a new partial class file and removed it from compilation when the targetframework is not netstandard2.1What I was not sure of, is how to add test for this feature.