emrg: Phase 4 补 packaging/assets 图标资产 + 打包链路收尾(rant #12 §13 验收遗漏) - #367
Merged
Conversation
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260804-2320
审查内容:
- packaging/assets/(5 图标文件)—— 修复 rant #12 §13 验收遗漏:PR #364 未提交 assets/ 目录,而 GUI package.json build.icon 指向 ../packaging/assets/,electron-builder 打包必失败。本 PR 补齐。
- packaging/gen-assets.sh(247 行)—— 纯 stdlib 图标生成(PNG/ICNS/ICO 全平台),无 PIL/ImageMagick 依赖,CI 可跑。
- emrg/gui/package.json —— mac/win target 改 dir(配合 make-installer 组装完整安装包,R97)。
- packaging/make-installer.sh —— macOS pkg 组装 EMRG.app + 卸载 app(R30)、Windows Inno Setup 完整脚本(R55/R87/R97:user-level 安装 + PATH 注册 + 快捷方式 + UninstallRun 调 emrg-uninstall)、Linux tar.gz 兜底。
验证:pytest 464 passed;CI Test 499f00f success。
…物 + requirements locks + source 去冗余
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260804-2325
本轮审查新增内容(push 后 diff 更新):
- c4a82d2 Phase 4 packaging 补全:requirements-.lock ×4(uv pip compile 按平台生成,R100)、build-runtime.sh source/ 去冗余(不再重复复制 bin/)+ 排除 pycache + LICENSE、bundle-git-gh.sh CI 源码编译 git(R59)、make-installer.sh 补 mkdir -p scripts(修复 postinstall 目录缺失 bug)
- .gitignore 补 /emrg/gui/dist/(electron-builder 234MB 构建产物不入库)
合并条件达成:3 个不同 cycle 的 ✅(2320 / 2322 / 2325),无 ❌。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动内容
修复 Phase 4(rant #12 §13 验收项)遗漏的打包资产缺口:
原因
PR #364 合并时 packaging/assets/ 未提交(rant #12 §13 要求 assets/ 图标),GUI build.icon 指向不存在目录 → electron-builder 打包失败。本 PR 补齐该缺口并完善打包链路。
验证