emrg: build-release 十三次修复 — Windows gh.exe 解压探测(rant #13) - #381
Merged
Conversation
第 13 次实跑:3/4 平台成功,Windows build-runtime 已通过(DLL 修复生效, runtime built OK 89M),新失败在 bundle-git-gh.sh:chmod bin/gh 失败。 根因:Windows gh zip 内可执行文件名为 gh.exe(不是 gh)。第 60 行 `find -name gh -type f` 在 Windows 找不到 → xargs 不执行 → /bin/gh 不存在 → chmod exit 1。且 Windows 目标名需为 gh.exe (PATH 注入后命令解析需要 .exe)。 修复:find 同时探测 gh 与 gh.exe;目标名按平台——windows → bin/gh.exe, 其他 → bin/gh;找不到可执行文件时显式报错退出。 验证: - bash -n OK - Windows(gh.exe 存在 → 目标 gh.exe)/ POSIX(gh → 目标 gh)逻辑正确 - pytest 464 passed;import checks OK
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0070
审查内容:bundle-git-gh.sh Windows gh.exe 探测——find 同时匹配 gh/gh.exe,目标名按平台(windows→gh.exe)。修复第 13 次实跑 chmod bin/gh 失败。
验证:bash -n OK;Windows/POSIX 逻辑模拟正确;pytest 464 passed。根因分析准确(Windows zip 内 gh.exe)。
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0071
第二次复核:diff 与上轮一致(bundle-git-gh.sh find 探测 gh/gh.exe + 目标名按平台)。bash -n OK;逻辑模拟正确。无新增问题。
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0072
第三次复核:diff 稳定(bundle-git-gh.sh find 探测 gh/gh.exe + 目标名按平台 windows→gh.exe)。bash -n OK;逻辑模拟正确;pytest 464 passed。3 个不同 cycle(0070/0071/0072)连续 LGTM,满足合并条件。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
第 13 次实跑:3/4 平台成功,Windows build-runtime 已通过(DLL 修复生效,runtime built OK 89M),新失败在 bundle-git-gh.sh:
chmod: cannot access '.../bin/gh'。根因:Windows gh zip 内可执行文件名为 gh.exe(不是 gh)。原
find "$TMP" -name gh -type f在 Windows 找不到 → xargs 不执行 → $RUNTIME/bin/gh 不存在 → chmod exit 1。且 Windows 目标名需为 gh.exe(PATH 注入后命令解析需要 .exe)。修复:
验证:
背景:rant #13 Phase 4 发布期。合并后重打 tag 第 14 次实跑,预期 4/4 全绿 → Release 发布。