emrg: build-release 十五次修复 — Inno 路径 cygpath 转 Windows(rant #13) - #383
Merged
Conversation
第 15 次实跑:3/4 平台成功(Windows build-runtime + bundle-git-gh 已通过), 新失败在 Inno 编译:emrg.iss 第 16 行 The system cannot find the path specified。 根因:iscc 是 Windows 原生程序,读不懂 Git Bash POSIX 路径。 .iss 中 OutputDir=/artifacts、SetupIconFile=/.../icon.ico、 Source="/payload\*" 均为 /d/a/emrg/emrg/... POSIX 形式 → iscc 找不到路径 → 编译失败(常量关已过,路径关没过)。 修复:Windows 段用 cygpath -m 将 ROOT/DIST/STAGE 转 Windows 路径 (正斜杠形式 D:/a/emrg/emrg,iscc 可读);cygpath 仅 Git Bash 有, 无则兜底保持原样。STAGE 在转换前创建(顺序修正)。 验证: - bash -n OK - 转换逻辑分支验证(有/无 cygpath 双路径) - pytest 464 passed;import checks OK
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0076
审查内容:make-installer.sh Windows 段 cygpath -m 转路径(ROOT/DIST/STAGE→Windows 形式),修 iscc 读不懂 POSIX 路径问题;STAGE 创建顺序修正。
验证:bash -n OK;转换逻辑分支验证(有/无 cygpath);pytest 464 passed。根因分析准确(第 15 次实跑 Inno 第 16 行路径不存在 = POSIX 路径)。
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0077
第二次复核:diff 与上轮一致(make-installer.sh Windows 段 cygpath -m 转 ROOT/DIST/STAGE + STAGE 顺序修正)。bash -n OK;双路径分支验证过。无新增问题。
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0078
第三次复核:diff 稳定(make-installer.sh cygpath -m 转 ROOT/DIST/STAGE + STAGE 顺序修正)。bash -n OK;双路径分支验证过;pytest 464 passed。3 个不同 cycle(0076/0077/0078)连续 LGTM,满足合并条件。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
第 15 次实跑:3/4 平台成功(Windows build-runtime + bundle-git-gh 已通过),新失败在 Inno 编译:
emrg.iss 第 16 行 The system cannot find the path specified。根因:iscc 是 Windows 原生程序,读不懂 Git Bash POSIX 路径。.iss 中 OutputDir=$DIST/artifacts、SetupIconFile=$ROOT/.../icon.ico、Source="$STAGE/payload\*" 均为 /d/a/emrg/emrg/... POSIX 形式 → iscc 找不到路径 → 编译失败(常量关已过,路径关没过)。
修复:Windows 段用
cygpath -m将 ROOT/DIST/STAGE 转 Windows 路径(正斜杠形式 D:/a/emrg/emrg,iscc 可读);cygpath 仅 Git Bash 有,无则兜底保持原样。STAGE 在转换前创建(顺序修正)。验证:
背景:rant #13 Phase 4 发布期。合并后重打 tag 第 16 次实跑,预期 4/4 全绿 → Release 发布。