emrg: build-release 十六次修复 — Inno 移除 [Tasks] 桌面图标 + iscc 版本诊断(rant #13) - #384
Merged
Conversation
第 16 次实跑:3/4 平台成功(Windows build-runtime + bundle-git-gh 通过,
Inno 常量关/路径关均过),新失败:emrg.iss 第 26 行
Parameter "Flags" includes an unknown flag([Tasks] 段 Flags: checked)。
推断:iscc 版本在 6.0.x({userhome} 需 6.1+ 报错→<6.1;
PrivilegesRequiredOverridesAllowed 通过→>=6.0),该版本对
[Tasks] 段某些 flag 兼容性异常。
修复:
1. 移除 [Tasks] 段(桌面快捷方式任务)及 [Icons] 中 Tasks: desktopicon
引用——桌面快捷方式非安装包核心功能,开始菜单入口保留
2. 编译前打印 iscc 版本(iscc /?)到 CI 日志——若还有其他
Flags 报错可据版本精准修复
验证:
- bash -n OK;无 Tasks/desktopicon 残留
- pytest 464 passed;import checks OK
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0079
审查内容:make-installer.sh 移除 [Tasks] 段(桌面图标)绕开 iscc 6.0.x flags 兼容问题 + 编译前打印 iscc 版本诊断。
验证:bash -n OK;无 Tasks/desktopicon 残留;pytest 464 passed。修复合理(桌面快捷方式非核心,开始菜单保留),版本诊断便于后续精准修复。
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0080
第二次复核:diff 与上轮一致(make-installer.sh 移除 [Tasks]/desktopicon + iscc /? 版本打印)。bash -n OK;无 Tasks 残留;pytest 464 passed。无新增问题。
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0081
第三次复核:diff 稳定(make-installer.sh 移除 [Tasks]/desktopicon + iscc /? 版本打印)。bash -n OK;pytest 464 passed。3 个不同 cycle(0079/0080/0081)连续 LGTM,满足合并条件。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
第 16 次实跑:3/4 平台成功(Windows build-runtime + bundle-git-gh 通过,Inno 常量关/路径关均过),新失败:
emrg.iss 第 26 行 Parameter \Flags\ includes an unknown flag([Tasks] 段 Flags: checked)。推断:iscc 版本在 6.0.x({userhome} 需 6.1+ 报错 → <6.1;PrivilegesRequiredOverridesAllowed 通过 → >=6.0),该版本对 [Tasks] 段某些 flag 兼容性异常。
修复:
验证:
背景:rant #13 Phase 4 发布期。合并后重打 tag 第 17 次实跑,预期 4/4 全绿 → Release 发布。