emrg: build-release 十九次修复 — smoke Windows 判断改 WINDIR 环境变量(rant #13) - #387
Merged
Conversation
第 19 次实跑 4 平台全失败(exit 127)——PR #386 引入回归: smoke-test.sh 的 Windows 判断 `[ -n "${WINDIR:-}" ] || [ -f .../emrgd.cmd ]` 在 macOS/Linux 误判为 Windows——build-runtime.sh 第 70 行跨平台复制 emrgd.cmd(POSIX 也有此文件)→ 文件探测恒真 → macOS 走 cmd 分支 → macOS 无 cmd 命令 → exit 127。 修复:Windows 判断只保留 ${WINDIR} 环境变量(Windows Git Bash 必有, macOS/Linux 无),去掉文件探测。2 处同步。 验证: - bash -n OK - macOS 模拟(无 WINDIR 但有 emrgd.cmd 文件)→ nohup ✓ - Windows 模拟(有 WINDIR)→ cmd ✓ - pytest 464 passed;import checks OK
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0088
审查内容:smoke-test.sh Windows 判断去掉文件探测(POSIX 也有 emrgd.cmd 导致误判),只保留 WINDIR 环境变量。修第 19 次 4 平台全失败回归。
验证:bash -n OK;macOS(无 WINDIR 有文件)→nohup / Windows(有 WINDIR)→cmd 模拟正确;pytest 464 passed。根因分析准确(emrgd.cmd 跨平台复制致文件探测恒真)。
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0089
第二次复核:diff 与上轮一致(smoke-test.sh Windows 判断去掉文件探测,只留 WINDIR)。bash -n OK;macOS/Windows 双模拟正确。无新增问题。
argszero
commented
Aug 4, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0090
第三次复核:diff 稳定(smoke-test.sh Windows 判断只留 WINDIR)。bash -n OK;双模拟正确;pytest 464 passed。3 个不同 cycle(0088/0089/0090)连续 LGTM,满足合并条件。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
第 19 次实跑 4 平台全失败(exit 127)——PR #386 引入回归。
根因:smoke-test.sh 的 Windows 判断
[ -n "${WINDIR:-}" ] || [ -f "$HOME/.emrg/install/bin/emrgd.cmd" ]在 macOS/Linux 误判为 Windows——build-runtime.sh 第 70 行跨平台复制 emrgd.cmd(POSIX 也有此文件)→ 文件探测恒真 → macOS 走cmd //c分支 → macOS 无 cmd 命令 → exit 127(smoke 第 2 步 daemon 启动即挂)。修复:Windows 判断只保留
${WINDIR}环境变量(Windows Git Bash 必有,macOS/Linux 无),去掉文件探测。2 处同步。验证:
背景:rant #13 Phase 4 发布期。合并后重打 tag 第 20 次实跑,预期 4/4 全绿 → Release 发布。