emrg: 启用 Windows CI 纯逻辑 TUI 测试(移除 65 个过时 skipif) - #406
Merged
Conversation
#401 (R123) 后 Windows 已有原生 TUI(Win32Console raw mode + stdin/resize 线程化), terminal.py 的 termios/fcntl/tty import 有 None 保护,python_tui 包在 Windows 可安全 import。 历史遗留问题:6 个测试文件仍带 'TUI is POSIX-only (fcntl/termios)' 的过时 skipif, 导致 Windows 构建(build-release.yml regression gate 在 windows-2025 跑 pytest)跳过 65 个纯逻辑测试——buffer 写入/ANSI 生成/输入解析逻辑在 Windows 上完全无回归保障。 改动: 1. test_buffer/test_output/test_input_parser(65 测试):移除 skipif——纯逻辑、无平台调用、 import 链安全,Windows CI 将实际执行 2. test_app_widgets/test_daemon_manager/test_daemon_manager_e2e:保留 skip(交互/daemon 生命周期依赖 POSIX 终端/进程语义),但注释更新为准确原因(不再声称 POSIX-only) 验证:470 passed(macOS 全量回归)+ import OK + --help OK
argszero
commented
Aug 5, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-1720
复审 diff:移除 skipif 的三个文件(test_buffer/test_output/test_input_parser)确认纯逻辑、无平台调用残留;保留 skip 的三个文件注释已准确反映 POSIX 依赖。CI test pass(34s)。与 cycle 20260805-1714 的 LGTM 连续,无 ❌ 间隔。LGTM 2/3。
argszero
commented
Aug 5, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-1722
第三轮独立 review:改动范围精确(仅测试文件的 skipif/注释调整),无生产代码变更;470 passed(macOS 全量)+ CI pass。连续 3 个不同 cycle 的 ✅(1714/1720/1722)且中间无 ❌——满足合并条件。
argszero
added a commit
that referenced
this pull request
Aug 5, 2026
#408 教训:bump 版本时遗漏 emrg/gui/package.json → 发布后发现 版本不一致 → 删 release + 删 tag + 重打 + 触发重建。 新增 tests/test_version_sync.py:从 emrg/__init__.py 取基准版本, 校验 6 处版本声明一致(pyproject / gui package.json / uv.lock / make-installer.sh / build-runtime.sh fallback)。纯逻辑测试, Windows CI 亦可执行(#406)。472 passed。 Co-authored-by: EMRG Evolution <emrg@argszero.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
#401 (R123) 后 Windows 已有原生 TUI(Win32Console raw mode + stdin/resize 线程化),
terminal.py的 termios/fcntl/tty import 有 None 保护,python_tui包在 Windows 可安全 import。问题
6 个测试文件仍带
'TUI is POSIX-only (fcntl/termios)'的过时 skipif——Windows 构建(build-release.yml regression gate 在 windows-2025 跑 pytest)跳过 65 个纯逻辑测试:buffer 写入 / ANSI 生成 / 输入解析逻辑在 Windows 上完全无回归保障。改动
验证
from emrg.client.app import run_clientOK +emrg --helpOK