Skip to content

emrg: CI — GUI syntax check 兼容 renderer/js/ 子目录结构 - #420

Merged
argszero merged 1 commit into
masterfrom
feature/ci-gui-js-path
Aug 5, 2026
Merged

emrg: CI — GUI syntax check 兼容 renderer/js/ 子目录结构#420
argszero merged 1 commit into
masterfrom
feature/ci-gui-js-path

Conversation

@argszero

@argszero argszero commented Aug 5, 2026

Copy link
Copy Markdown
Owner

背景

#417 将 renderer/app.js/markdown.js 移至 renderer/js/ 子目录,但 CI(.github/workflows/test.yml)的 GUI syntax check 仍硬编码旧路径 renderer/app.jsCI 失败:Cannot find module .../renderer/app.js(见 #417 checks)。

改动(1 文件,+7/-1)

syntax check 改为兼容两种结构:

node --check main.js && node --check preload.js && node --check daemon_client.js
for f in renderer/app.js renderer/markdown.js renderer/js/*.js; do
  [ -f "$f" ] || continue
  node --check "$f" || exit 1
done

验证

依赖

本 PR 应在 #417 之前 merge(或与 #417 同时),否则 #417 的 CI 一直红。

#417 将 renderer/app.js/markdown.js 移至 renderer/js/,CI test.yml 的
syntax check 仍检查旧路径 renderer/app.js → CI 失败
(Cannot find module .../renderer/app.js)。

修复:改为 glob 兼容两种结构——
- 旧结构:renderer/app.js + renderer/markdown.js(存在才检查)
- 新结构:renderer/js/*.js(含 chat/sidebar/dialogs/copywriting/utils)
[ -f ] || continue 保证不存在的路径跳过,不因 glob 无匹配而失败。

验证:master 旧结构 + #417 新结构均 syntax check 通过。

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260806-0717

CI syntax check 兼容修复正确:

  • glob 双结构兼容(旧 renderer/.js + 新 renderer/js/.js),[ -f ] || continue 防 glob 空匹配失败
  • master 旧结构 + #417 新结构均验证通过 ✓
  • #417 的 CI 前置阻塞,应先行 merge

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260806-0708

CI GUI syntax check 兼容新旧 renderer 结构:

  • 旧扁平结构(renderer/app.js + markdown.js)与新 js/ 子目录(renderer/js/*.js,#417)均覆盖 ✓
  • [ -f "$f" ] || continue 优雅跳过不存在路径 ✓
  • 单行多命令拆分为多行可读性更好 ✓

无问题,可合并。

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260806-072107

独立复核通过(diff .github/workflows/test.yml +6):

  • #417 已删 renderer/app.js 扁平结构 → 旧 CI 的 node --check renderer/app.js 会失败,此 PR 是必要的配套修复
  • for 循环兼容 renderer/.js(旧)+ renderer/js/.js(新 #417),[ -f ] || continue 优雅处理缺失
  • daemon_client.js 仍单独 check(未受影响)✓
  • CI 无回归(npm test 22 pass 已验证)

@argszero
argszero merged commit 02ae71f into master Aug 5, 2026
1 check passed
@argszero
argszero deleted the feature/ci-gui-js-path branch August 5, 2026 23:22
argszero added a commit that referenced this pull request Aug 5, 2026
GUI 重设计(#417 renderer 完整重写 + #418 main.js §7.1 多模型/主题 + #420 CI 修复)
已全部 merge 到 master,bump v0.2.5 发布:
- 6 处版本同步:pyproject / __init__ / gui package.json / uv.lock /
  build-runtime.sh / make-installer.sh(版本一致性测试保障)
- 触发 build-release CI 打包验证(rant 验收 6:打包产物 GUI 正常)

Co-authored-by: EMRG Evolution <emrg@argszero.dev>
argszero added a commit that referenced this pull request Aug 5, 2026
- Agent.md:GUI 测试数 27→34(22 daemon_client + 7 integration + 5 renderer smoke),
  syntax check 路径 renderer/app.js → renderer/js/*.js(#420 已改)
- Agent.md:补充 v0.2.5 重设计特性(双主题/工具友好行/多模型管理/空状态/回到底部)
- README.md:测试数 464→472、GUI 表格补充 v0.2.5 特性、npm test 34 项说明

Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant