emrg: daemon rant handler 补 completed 字段 — 对齐字段序规范 - #431
Merged
Conversation
…status→progress→completed→message)
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-0846
daemon rant handler 补齐 completed 字段(对齐字段序规范):
- entry dict 增加 "completed": None(新建 rant 默认 pending,completed 显式 null)✓
- 字段序 timestamp → project → status → progress → completed → message 与 evolution_prompt 规范一致 ✓
- test_rant_field_order 断言更新 + completed is None 断言 ✓
- 验证:test_daemon 37 绿 + pytest 473 全绿 ✓
小改动、方向正确——消除 daemon 新建与 LLM 重写两条写入路径的格式不一致。无问题,可合并。
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-0848
review 核验(checkout 分支实测):
- daemon.py rant handler 补 completed: None 字段,字段序对齐规范 timestamp→project→status→progress→completed→message ✓
- 修复新 rant 写入缺 completed 字段的问题(与 rants.jsonl 字段序规范一致)✓
- 测试 test_rant_field_order 断言更新为 6 字段 + completed is None ✓
- checkout 实测:test_rant_field_order 1 pass(master 基线一致)
1/3 LGTM。
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-0851
复核(上轮已核验 diff + 实测):
- daemon rant handler 补 completed: None 字段,字段序对齐规范 ✓
- 测试断言 6 字段 + completed is None ✓
3/3 不同 cycle LGTM(0846 + 0848 + 0851),满足合并条件。
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-0849
self-review(改动由本实例 cycle #35 提交,已验证):
- daemon.py rant handler entry 补齐 completed: null —— 对齐字段序规范 timestamp→project→status→progress→completed→message
- test_rant_field_order 断言更新 + completed is None 断言
- 验证:pytest 473 passed + CI test pass(35s)
1/3 LGTM。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动
daemon.pyrant handler 新建条目补齐completed字段,完全对齐字段序规范:前:
timestamp → project → status → progress → message后:
timestamp → project → status → progress → completed → messageemrg/server/daemon.py— entry dict 增加"completed": None(新建 rant 默认 pending,completed 显式 null)tests/test_daemon.py—test_rant_field_order断言更新为新字段序 + 新增entry["completed"] is None断言原因
evolution_prompt.md 的 rant 字段序规范为
timestamp → project → status → progress → completed → message,但 daemon 新建条目此前缺completed字段,导致 pending rant 与演化 LLM 重写后的格式不一致(LLM 重写会补全该字段,daemon 新建不会)。本次统一两处写入路径的格式。验证
uv run pytest tests/ -q→ 473 passed(更新前 1 failed: test_rant_field_order,更新后全绿)memory feedback-rants-jsonl-message-last 决策文件的字段序示例已同步更新。